Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for daily failures #2286

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fixes for daily failures #2286

merged 1 commit into from
Jan 30, 2025

Conversation

fedinskiy
Copy link
Contributor

Summary

  • Message for generated certificates has changed

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend the commit message to just say Message for generated certificates has changed instead of Fixes for daily failures:

@fedinskiy
Copy link
Contributor Author

@rsvoboda this is work in progress for now, and there is a chance, that more chance are be required. I will change the message, if this fix would be the only one.

@rsvoboda
Copy link
Member

Better to have commit per fix

@fedinskiy
Copy link
Contributor Author

It turns out OIDC failure for daily were either temporary or have been already fixed. I've changed the commit message.

@rsvoboda rsvoboda merged commit e1461fe into main Jan 30, 2025
7 checks passed
@fedinskiy fedinskiy deleted the fix/daily branch January 30, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants