Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql coverage #446

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Graphql coverage #446

merged 1 commit into from
Jan 10, 2022

Conversation

fedinskiy
Copy link
Contributor

@fedinskiy fedinskiy commented Jan 5, 2022

Coverage for quarkusio/quarkus#20293

TODOs:

  • Merge commits together

@fedinskiy fedinskiy requested a review from pjgg January 5, 2022 14:54
@fedinskiy fedinskiy force-pushed the feature/graphql branch 2 times, most recently from afdd65a to 1eb3e16 Compare January 6, 2022 16:10
@fedinskiy fedinskiy requested a review from pjgg January 7, 2022 15:55
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedinskiy
Copy link
Contributor Author

Have a look this comment in order to proceed https://github.com/quarkus-qe/quarkus-test-suite/pull/446/files#r781051952

Discussed in private messages, considered less readable.

@fedinskiy fedinskiy requested a review from pjgg January 10, 2022 10:38
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjgg pjgg merged commit b9aee2c into quarkus-qe:main Jan 10, 2022
@fedinskiy fedinskiy mentioned this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants