Test MessageBodyWriters resources works in native mode
#765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verifies: quarkusio/quarkus#25385 When we provide `MessageBodyWriter` that does not extend `ServerMessageBodyWriter`, related resource methods must be registered for the reflection. Previously, we had to do this manually, now it's done by the Quarkus for us. Reproducer 1. go to Quarkus project 2. revert PR `git revert 224ec8c3e8e50930970e9c8b7316622ba898b0b9` 3. checkout this PR 4. `cd quarkus-test-suite/http/http-advanced-reactive` 5. run `mvn clean verify -Dit.test=HttpAdvancedReactiveIT -Dnative`
|
I doubt the test failure is related as the same failure is present in daily CI run. I'm looking into it anyway. |
|
Green now :-) |
jsmrcka
approved these changes
Jul 26, 2022
michalvavrik
deleted the
feature/test-messagebodywriter-resources-in-native
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
verifies: quarkusio/quarkus#25385
When we provide
MessageBodyWriterthat does not extendServerMessageBodyWriter, related resource methods must be registered for the reflection. Previously, we had to do this manually, now it's done by the Quarkus for us.Issue reproducer
git revert 224ec8c3e8e50930970e9c8b7316622ba898b0b9andmvn -Dquicklycd quarkus-test-suite/http/http-advanced-reactivemvn clean verify -Dit.test=HttpAdvancedReactiveIT -DnativePlease select the relevant options.
Checklist: