Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Scenario: RequestScope custom context was removed after javax.enterprise event propagation #996

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented Jan 16, 2023

Summary

When firing an async CDI Event, the requestScope context from the emitter briefly exists for the observer and is then terminated. This commit is a reproducer of this scenario that happens on Quarkus 2.13.0.Final

How to reproduce

mvn clean verify -Dit.test=HttpAdvancedIT#keepRequestScopeValuesAfterEventPropagation -Dquarkus.platform.version=2.13.0.Final -Dquarkus.platform.group-id=io.quarkus.platform

Please select the relevant options.

  • New scenario (non-breaking change which adds functionality)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@pjgg pjgg added the triage/backport-2.13? It needs to backport changes to branch 2.13 label Jan 16, 2023
@pjgg pjgg requested a review from fedinskiy January 16, 2023 16:14
@pjgg pjgg force-pushed the QUARKUS-2785 branch 2 times, most recently from 9f4d78b to 3c54469 Compare January 16, 2023 16:23
…terprise` event propagation

When firing an async CDI Event, the requestScope context from the emitter briefly exists for the observer
and is then terminated. This commit is a reproducer of this scenario that happens on Quarkus 2.13.0.Final
@pjgg pjgg added triage/backport-2.7? It needs to backport changes to branch 2.7 and removed triage/backport-2.13? It needs to backport changes to branch 2.13 labels Jan 17, 2023
@fedinskiy fedinskiy merged commit a7202b7 into quarkus-qe:main Jan 17, 2023
@pjgg pjgg added triage/backport-2.13? It needs to backport changes to branch 2.13 and removed triage/backport-2.7? It needs to backport changes to branch 2.7 labels Jan 17, 2023
@pjgg pjgg added this to the 2.7 milestone Feb 2, 2023
@pjgg pjgg removed the triage/backport-2.13? It needs to backport changes to branch 2.13 label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants