Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC and SSE coverage for OpenTelemetry #999

Merged
merged 1 commit into from
Jan 18, 2023
Merged

gRPC and SSE coverage for OpenTelemetry #999

merged 1 commit into from
Jan 18, 2023

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Jan 17, 2023 •
edited
Loading

gRPC and SSE coverage for OpenTelemetry

Partial port of the coverage from https://github.com/quarkus-qe/quarkus-test-suite/tree/main/monitoring/opentracing-reactive-grpc + small rework.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda rsvoboda force-pushed the opentelemetry.sse.grpc branch from cd29801 to 16519f3 Compare January 17, 2023 14:55
@rsvoboda rsvoboda requested a review from mjurc January 17, 2023 15:04
rsvoboda
rsvoboda commented Jan 17, 2023
View reviewed changes
...lemetry-reactive/src/test/java/io/quarkus/ts/opentelemetry/reactive/OpenTelemetryGrpcIT.java Outdated
@QuarkusScenario
public class OpenTelemetryGrpcIT {

@JaegerContainer(useOtlpCollector = true, image = "quay.io/jaegertracing/all-in-one:1.41.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I should drop quay.io/jaegertracing/all-in-one:1.41.0 occurrences and update the default in framework.

Waiting till the review is done and CI run finished.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed, can we have this in framework too?

We can update this after framework with version bump is released - or we can hold this MR up until framework is released.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My PR worked with both versions, we can merge. I will handle version bump in the FW by the end of the week.

mjurc
mjurc approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the call to be made, this can be merged. Thanks for update.

...lemetry-reactive/src/test/java/io/quarkus/ts/opentelemetry/reactive/OpenTelemetryGrpcIT.java Outdated
@QuarkusScenario
public class OpenTelemetryGrpcIT {

@JaegerContainer(useOtlpCollector = true, image = "quay.io/jaegertracing/all-in-one:1.41.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed, can we have this in framework too?

We can update this after framework with version bump is released - or we can hold this MR up until framework is released.

@rsvoboda rsvoboda force-pushed the opentelemetry.sse.grpc branch from 16519f3 to f327c60 Compare January 18, 2023 11:41
@rsvoboda
Copy link
Member Author

quay.io/jaegertracing/all-in-one:1.41.0 dropped

@rsvoboda rsvoboda added the triage/backport-2.13? It needs to backport changes to branch 2.13 label Jan 18, 2023
@mjurc mjurc merged commit c0cecb4 into quarkus-qe:main Jan 18, 2023
@pjgg pjgg mentioned this pull request Jan 30, 2023
Merged
1 task
@pjgg pjgg added this to the 2.7 milestone Feb 2, 2023
@pjgg pjgg removed the triage/backport-2.13? It needs to backport changes to branch 2.13 label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc mjurc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@rsvoboda @mjurc @pjgg