Save the result of Path.toUri() #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting a path multiple times to its URI representation is costly. This call can easily be cached for the sysfs path to the zip, since paths themselves are immutable.
|
/cc @aloubyansky Might be of interest to you. |
aloubyansky
approved these changes
Dec 23, 2021
|
In the meantime, I've released 0.0.6 including this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting a path multiple times to its URI representation is costly. This call can easily be cached for the sysfs path to the zip, since paths themselves are immutable.
Everytime the URI for a specific file inside a zip is created, .toURI of the original sysfs path is first called. These calls can be easily intercepted thanks to the delegates we have in place.
Saves about 250ms of dev mode startup time on quarkusio/quarkus#22336 (6d572df).
Saves about 5ms of dev mode startup time on main
Related to quarkusio/quarkus#21552