Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test artifacts version should be equal to the version of the test list #91

Open
ppalaga opened this issue Nov 17, 2021 · 2 comments
Open

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Nov 17, 2021

This was not supposed to work before 0.0.32, so I implemented this workaround in the XSL:

I tested again with 0.0.37, and IMO it still does not work. Maybe I am doing something wrong.

This is what I am doing:

  1. Initial state (the one containing the workaround) is commit b2f3adb2055f500346842f31c528493ef0c0ea27 from this branch: https://github.com/ppalaga/quarkus-platform/commits/i91
  2. Remove the workaround in the XSL: ppalaga/quarkus-platform@11815a1#diff-83ce56bfbc63c6c743ed24689a3e000a2a06e2857c874c85c82b9ca19149c73aL52
  3. Regenerate the BOMs via mvn clean install -DskipTests -Prhproduct -Denforcer.skip

EXPECTED: Either no change in the generated tests like this one ppalaga/quarkus-platform@11815a1#diff-5046a7d2bf1acb6e6f9c6049180329b7fdb3a06e2f39d28345776aad6df1df06L15-R15 or only changes do not cause the tests fail. Expected is that all test artifacts have the community version , ${camel-quarkus-tests.version} set in the rhproduct profile.

ACTUAL: Test artifacts in the generated test modules have ${camel-quarkus.version}. That's the productized version for the rhproduct profile. Some Camel Quarkus Test artifacts do not exist in this version (because they were intentionally not productized) and thus some tests cannot be compiled.

ppalaga added a commit to ppalaga/quarkus-platform that referenced this issue Nov 17, 2021
@ppalaga
Copy link
Contributor Author

ppalaga commented Dec 2, 2021

OK, I see this should be fixed since version 0.0.42 #73

@ppalaga
Copy link
Contributor Author

ppalaga commented Dec 2, 2021

I tried with 0.0.42 and it still does not work. Same steps as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant