Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Connection timed out (Read failed) on Azure by setting maven.wa… #69

Merged
merged 1 commit into from
May 14, 2020

Conversation

ppalaga
Copy link
Collaborator

@ppalaga ppalaga commented May 14, 2020

…gon.httpconnectionManager.ttlSeconds

@geoand we were struggling with this kind of issues in Camel Quarkus for some time.

There is some background info in https://issues.apache.org/jira/browse/WAGON-486 and https://issues.apache.org/jira/browse/WAGON-545

I hope azure pipelines is using a Maven version new enough to pick ./mvn/maven.config

@geoand
Copy link
Contributor

geoand commented May 14, 2020

That's nice!

Do we perhaps need to do anything else to make https://github.com/quarkusio/quarkus-platform/blob/master/.github/quarkus-ecosystem-test#L5 pick up these settings?

@ppalaga
Copy link
Collaborator Author

ppalaga commented May 14, 2020

That's nice!

Do we perhaps need to do anything else to make https://github.com/quarkusio/quarkus-platform/blob/master/.github/quarkus-ecosystem-test#L5 pick up these settings?

No, if you use maven 3.3.1+ https://maven.apache.org/docs/3.3.1/release-notes.html#jvm-and-command-line-options

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@famod
Copy link
Member

famod commented Apr 1, 2021

@ppalaga Any reason why you didn't use .mvn/jvm.config instead? My understanding from the Maven docs is that maven.config should be used for mvn arguments like --fail-at-end etc.
Reason I'm asking is that I want to set -Dkotlin.environment.keepalive=true in the main repo to work around https://youtrack.jetbrains.com/issue/KT-45007

@ppalaga
Copy link
Collaborator Author

ppalaga commented Apr 2, 2021

-D options might work in both files hard to say whether it makes any difference.

@famod
Copy link
Member

famod commented Apr 2, 2021

Ok, thanks for your feedback.
FWIW, it seems that jvm.config is added to MAVEN_OPTS somewhere in the scripts whereas maven.config is read in some CLI class in maven-embedder. So I guess things like locale etc. that have to be set early on to take effect have to be in jvm.config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants