Add CI for PRs to QuickStarts #138
Comments
|
So, I'm all for getting back CI on quickstarts. The issue is that we don't publish the snapshots right now so it's not as easy as it looks. We run a full quickstart testing before releasing but the bootstrap issue apparently needs some special circumstances to happen (I still can't reproduce it). For now, the version bump is directly pushed by a script so it's not dealt with as a PR but tests are run before pushing it. So +1 but that needs work. |
@gsmet but we don't have to, or at least not just to enable CI, right? What I'm suggesting is really "just" CI for all PRs, nothing per se specific to version bump release processes, and without SNAPSHOT support... Because the POMs in this repo (quickstarts) do NOT actually use 999-SNAPSHOT (may be they used to, but at least on current master they do not). So a future release version bump is "just another PR", which bumps from a (again, non-SNAPSHOT) say 0.13.0 to a 0.14.0 or whatever - which CI can verify - like any other change.
That's probably also a Good Idea, but kind of separate and just a parallel pre-req to this suggestion? (I'm assuming that the script used to do this changes all versions to 999-SNAPSHOT; but that's temporary and not committed to this repo, or not anymore - it seems.) |
|
I've started working on it. |
|
@cescoffier what's the status and overall plan ? Will we publish snapshots or CI pipeline will build Quarkus latest bits ? |
|
I have started working on this, but we are facing a lot of connection issue with maven central and make our CI approach not really suitable for this.
… On 26 Apr 2019, at 11:35, Rostislav Svoboda ***@***.***> wrote:
@cescoffier what's the status and overall plan ?
Will we publish snapshots or CI pipeline will build Quarkus latest bits ?
mvn clean install -DskipTests -DskipITs on Quarkus is quite fast
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Just to give more details. snapshots are deployed every night (it takes roughly 3h to get them deployed). What does not work is building the quickstarts as the connection to maven central and OSS snapshots is terribly slow (several hours for a single QuickStart). We cannot use mirror on snapshots (it defeats a bit the purpose).
I’ve looked at alternative like hosting a Maven repo on azure file system but not very convincing at the moment.
… On 26 Apr 2019, at 17:05, clement escoffier ***@***.***> wrote:
I have started working on this, but we are facing a lot of connection issue with maven central and make our CI approach not really suitable for this.
> On 26 Apr 2019, at 11:35, Rostislav Svoboda ***@***.***> wrote:
>
> @cescoffier what's the status and overall plan ?
>
> Will we publish snapshots or CI pipeline will build Quarkus latest bits ?
> mvn clean install -DskipTests -DskipITs on Quarkus is quite fast
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Aside infrastructure challenges I think CI should cover (in the end) these combinations:
|
|
@cescoffier / @gsmet ... any plans to have at least QS run in JVM mode on Windows There is just ubuntu one - https://github.com/quarkusio/quarkus-quickstarts/blob/main/.github/workflows/build-pr-development.yml#L10 |
Perhaps it would be useful to validate all PRs proposed to this repo (Quick Starts) by CI?
May be that would caught quarkusio/quarkus#1918 if 8af8b36 was run through a PR with CI.
Such a CI job could also run the Gradle Getting Started (see #136).
Just a thought.
The text was updated successfully, but these errors were encountered: