Fix Gradle plugin id and parameterize the Quarkus version #140
Conversation
| } | ||
|
|
||
| repositories { | ||
| mavenLocal() |
There was a problem hiding this comment.
This really shouldn't be required? The build is more stable and reproducible without this, and we shouldn't promote needing it IMHO.
There was a problem hiding this comment.
You can't build the development branch without it as we don't publish snapshots.
There was a problem hiding this comment.
so in an ideal world, this would be yanked by the script doing the releasing, but I guess that's minor
| @@ -0,0 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
There was a problem hiding this comment.
Having the Gradle wrapper duplicated inside each quickstart is not required IMHO. There already is one at the root, and the documentation here already suggests to use ../gradlew. (I saw that the Maven wrapper is equally duplicated everywhere; if anything, I'd put a single Maven wrapper at the root instead as well.)
There was a problem hiding this comment.
Well, I had to look for it. So I'm pretty sure people will look for it too. That's why I added it.
There was a problem hiding this comment.
Personally I hate seeing this many checked in JAR files, but anyway.
| @@ -1,16 +1,16 @@ | |||
| plugins { | |||
| id 'java' | |||
| id 'io.quarkus.gradle.plugin' version '0.12.0' | |||
| id 'io.quarkus' | |||
There was a problem hiding this comment.
Sorry, but from where come the version in this case?
There was a problem hiding this comment.
Sorry, got it, was set below.
No description provided.