-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gradle #75
Comments
quarkusio/quarkus#1323 is now fixed, and when there is a new Quarkus 0.12.0 release I'll bump the versions in getting-started/build.gradle of master...vorburger:gradle and raise a PR from that branch. |
@jnizet given your quarkusio/quarkus#1403, shout via comments here if you have an feedback on master...vorburger:gradle ... (no PR actually raised yet, as waiting for release, or if you prefer I could raise a DRAFT PR that you can edit?). |
@vorburger My feedback would be to rey to avoid Applying plugins imperatively that way is discouraged for a long time by Gradle in favor of using the plugins block. The main reasons are that
For example, if you use
to configure the Quarkus extension. Instead, you need to add an import for the extension, and use something like
Same for configuring the tasks added by the plugin: you don't benefit anymore for the type-safe, auto-completable extensions provided by Gradle when a plugin is applied by the plugins block. See https://docs.gradle.org/current/userguide/plugins.html#sec:plugins_block for more information. |
@jnizet I've done this in commit be5712a on #90 - would you like to review?
This happened in today's commit 9743fd7 on #90 - now ready for merge, from my side. |
started in master...vorburger:gradle
currently blocked by quarkusio/quarkus#1323
@stalep FYI
The text was updated successfully, but these errors were encountered: