Improve the Gradle tooling documentation #1403
Conversation
- Provide Gradle Kotlin DSL examples - Avoid applying the plugins imperatively, as recommended, for a better integration of the Gradle Kotlin DSL - Use the project settings to download the plugin, instead of modifying the global Gradle settings - Use the Gradle wrapper in the shell examples - Fix a typo in the Eclipse integration See https://github.com/jnizet/quarkus-modern-gradle-example for a project using the Gradle code suggested in this commit (the kotlin-dsl branch contains the example using the Kotlin DSL)
| testCompile group: 'io.rest-assured', name: 'rest-assured', version: '3.3.0' | ||
| dependencies { <2> | ||
| compileOnly 'io.quarkus:quarkus-resteasy:{quarkus-version}' | ||
| compileOnly 'io.quarkus:quarkus-arc:{quarkus-version}' |
There was a problem hiding this comment.
I think quarkus-arc is transitively implicit? It works for me without this over in quarkusio/quarkus-quickstarts#75 (see quarkusio/quarkus-quickstarts@master...vorburger:gradle)
There was a problem hiding this comment.
If it's confirmed that it's not needed, then the getting started guide using Maven (https://quarkus.io/guides/getting-started-guide) (which I used as a basis for this gradle example) should probably be modified, too: it adds the arc dependency explicitly.
There was a problem hiding this comment.
@jnizet it's not strictly required because indeed transitive (just verified), but I just noticed that it's everywhere (also in all quickstarts), so I guess the idea is that it's clearer to have it explicit (perhaps to illustrate that you could ditch quarkus-resteasy and still use just quarkus-arc); therefore please ignore this point and keep it here as well - sorry for the confusion.
There was a problem hiding this comment.
@jnizet I confirm the arc dependency is not necessary. I'll fix the Maven getting started guide.
There was a problem hiding this comment.
@gsmet it's also in all the quickstarts ...
|
/Cc @stalep you may want to have a look over (or help review) this PR, if you have time. |
| testCompile group: 'io.rest-assured', name: 'rest-assured', version: '3.3.0' | ||
| dependencies { <2> | ||
| compileOnly 'io.quarkus:quarkus-resteasy:{quarkus-version}' | ||
| compileOnly 'io.quarkus:quarkus-arc:{quarkus-version}' |
There was a problem hiding this comment.
@jnizet I confirm the arc dependency is not necessary. I'll fix the Maven getting started guide.
| <2> The buildscript block can be omitted if you added it to your '~/.gradle/init.gradle' file. | ||
| <3> The repositories block can be omitted if you added it to your '~/.gradle/init.gradle' file. | ||
| <4> This dependency is needed for a rest application similar to the getting started example. | ||
| <2> These dependencies are needed for a rest application similar to the getting started example. |
|
@gsmet done. |
- rest -> REST - remove unnecessary arc dependency
See https://github.com/jnizet/quarkus-modern-gradle-example for a project using the Gradle code suggested in this commit (the kotlin-dsl branch contains the example using the Kotlin DSL)