Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixes #4480] OIDC Code Flow Quickstart #337

Merged
merged 1 commit into from
Oct 30, 2019
Merged

[fixes #4480] OIDC Code Flow Quickstart #337

merged 1 commit into from
Oct 30, 2019

Conversation

pedroigor
Copy link
Contributor

@pedroigor pedroigor commented Oct 26, 2019 •
edited
Loading

No description provided.

@pedroigor pedroigor mentioned this pull request Oct 26, 2019
Merged
cescoffier
cescoffier requested changes Oct 29, 2019
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires:

  1. a readme with the instructions to run the quickstarts
  2. tests (both JVM and native)

@pedroigor
Copy link
Contributor Author

@cescoffier Tks for the review. Both items were added.

cescoffier
cescoffier requested changes Oct 29, 2019
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to give more details about Keycloak, and start KC in the test.

openid-connect-web-authentication/src/test/java/org/acme/quickstart/oidc/CodeFlowTest.java
import io.restassured.RestAssured;

@QuarkusTest
public class CodeFlowTest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to start KC from the test.
I've found an example using TestContainer:

https://github.com/cremich/testcontainers-keycloak/blob/master/src/test/java/dev/cremich/testcontainers/utils/KeycloakContainerTest.java#L21-L31

Can this be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll give it a try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cescoffier Using testcontainers. As anything with Docker, users might experience unexpected errors due to environment settings. But it is indeed, a nice way to run tests using a container and an alternative to fabric8 plug-in.

@cescoffier cescoffier merged commit b7bc5e2 into quarkusio:development Oct 30, 2019
@cescoffier
Copy link
Member

I've merged it manually, because of the big rename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedroigor @cescoffier