Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Data REST quickstart #714

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Spring Data REST quickstart #714

merged 1 commit into from
Jan 21, 2021

Conversation

gytis
Copy link

@gytis gytis commented Nov 19, 2020

cc @geoand

@gytis gytis mentioned this pull request Nov 19, 2020
Merged
@gytis
Copy link
Author

gytis commented Nov 19, 2020

The extension PR quarkusio/quarkus#13373

@geoand
Copy link
Collaborator

geoand commented Nov 20, 2020

Let's relaunch CI when the extension is merged into the Quarkus repo

@gsmet gsmet mentioned this pull request Jan 20, 2021
Closed
@gsmet
Copy link
Member

gsmet commented Jan 20, 2021

Force pushed a rebase on top of latest development branch.

@gytis
Copy link
Author

gytis commented Jan 21, 2021

Seems that the database setup for the tests is wrong. I'll fix it.

aureamunoz
aureamunoz reviewed Jan 21, 2021
View reviewed changes
Copy link
Member

@aureamunoz aureamunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that a DB should be automatically started started like here @gytis

@gsmet
Copy link
Member

gsmet commented Jan 21, 2021

@gytis don't forget to either pull the rebase or rebase it yourself as we had other issues.

@aureamunoz
Copy link
Member

hahah, sorry @gytis I had not seen your comment when I add mine :-S

@gytis
Copy link
Author

gytis commented Jan 21, 2021

@gsmet fixed.

@gsmet
Copy link
Member

gsmet commented Jan 21, 2021

OK, thanks!

@gsmet gsmet merged commit 60a95ce into quarkusio:development Jan 21, 2021
@gytis gytis deleted the spring-data-rest branch January 21, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aureamunoz aureamunoz aureamunoz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gytis @geoand @gsmet @aureamunoz