Improve descriptions and categories in Camel recipes #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JiriOndrusek you happy with it? |
JiriOndrusek
reviewed
Mar 7, 2024
recipes/src/main/resources/quarkus-updates/org.apache.camel.quarkus/camel-quarkus/3alpha.yaml
Outdated
Show resolved
Hide resolved
|
@gsmet @jkschneider thank you for improving the description and categories. I found 1 description, where the the version should be changed (see the comment above), the rest seems ok |
gsmet
approved these changes
Mar 15, 2024
|
Thanks! |
|
Not that this one's in we have a couple more improvements based on our OpenRewrite best practice recipes. You can create a PR from this link, based on https://app.moderne.io/recipes/org.openrewrite.recipes.OpenRewriteBestPractices previewdiff --git a/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustApplicationPropertiesWithJakarta.java b/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustApplicationPropertiesWithJakarta.java
index c713fc0..6132793 100644
--- a/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustApplicationPropertiesWithJakarta.java
+++ b/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustApplicationPropertiesWithJakarta.java
@@ -1,18 +1,19 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.core.quarkus30;
-import lombok.EqualsAndHashCode;
-import lombok.Value;
+import java.util.Arrays;
+import java.util.List;
+
import org.openrewrite.*;
import org.openrewrite.internal.StringUtils;
import org.openrewrite.internal.lang.Nullable;
import org.openrewrite.properties.PropertiesVisitor;
import org.openrewrite.properties.tree.Properties;
-import java.util.Arrays;
-import java.util.List;
+import lombok.EqualsAndHashCode;
+import lombok.Value;
@Value
-@EqualsAndHashCode(callSuper = true)
+@EqualsAndHashCode(callSuper = false)
public class AdjustApplicationPropertiesWithJakarta extends Recipe {
static final List<String> JAKARTA_PACKAGES = Arrays.asList(
diff --git a/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustKotlinAllOpenDirectives.java b/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustKotlinAllOpenDirectives.java
index 10bad07..1d45c43 100644
--- a/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustKotlinAllOpenDirectives.java
+++ b/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustKotlinAllOpenDirectives.java
@@ -15,7 +15,7 @@ io.moderne.worker.execution.RecipeMapper
import lombok.Value;
@Value
-@EqualsAndHashCode(callSuper = true)
+@EqualsAndHashCode(callSuper = false)
public class AdjustKotlinAllOpenDirectives extends Recipe {
private static final String ALL_OPEN_ANNOTATION = "all-open:annotation=";
diff --git a/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustApplicationYamlWithJakarta.java b/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustApplicationYamlWithJakarta.java
index b2fd857..c73c5fb 100644
--- a/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustApplicationYamlWithJakarta.java
+++ b/recipes/src/main/java/io/quarkus/updates/core/quarkus30/AdjustApplicationYamlWithJakarta.java
@@ -10,7 +10,7 @@ io.moderne.worker.execution.RecipeMapper
import lombok.Value;
@Value
-@EqualsAndHashCode(callSuper = true)
+@EqualsAndHashCode(callSuper = false)
public class AdjustApplicationYamlWithJakarta extends Recipe {
@Override
diff --git a/recipes/src/main/java/io/quarkus/updates/core/quarkus39/RemoveMavenCompilerAnnotationProcessor.java b/recipes/src/main/java/io/quarkus/updates/core/quarkus39/RemoveMavenCompilerAnnotationProcessor.java
index 6d60682..2959595 100644
--- a/recipes/src/main/java/io/quarkus/updates/core/quarkus39/RemoveMavenCompilerAnnotationProcessor.java
+++ b/recipes/src/main/java/io/quarkus/updates/core/quarkus39/RemoveMavenCompilerAnnotationProcessor.java
@@ -14,7 +14,7 @@ io.moderne.worker.execution.RecipeMapper
import lombok.Value;
@Value
-@EqualsAndHashCode(callSuper = true)
+@EqualsAndHashCode(callSuper = false)
public class RemoveMavenCompilerAnnotationProcessor extends Recipe {
@Option(displayName = "Annotation processor groupId", description = "The groupId of the annotation processor.", example = "org.hibernate.orm", required = true)
diff --git a/recipes/src/main/java/io/quarkus/updates/core/quarkus37/AddMavenCompilerAnnotationProcessor.java b/recipes/src/main/java/io/quarkus/updates/core/quarkus37/AddMavenCompilerAnnotationProcessor.java
index c082042..99afa37 100644
--- a/recipes/src/main/java/io/quarkus/updates/core/quarkus37/AddMavenCompilerAnnotationProcessor.java
+++ b/recipes/src/main/java/io/quarkus/updates/core/quarkus37/AddMavenCompilerAnnotationProcessor.java
@@ -19,7 +19,7 @@ io.moderne.worker.execution.RecipeMapper
import lombok.Value;
@Value
-@EqualsAndHashCode(callSuper = true)
+@EqualsAndHashCode(callSuper = false)
public class AddMavenCompilerAnnotationProcessor extends Recipe {
@Option(displayName = "Annotation processor groupId", description = "The groupId of the annotation processor.", example = "org.hibernate.orm", required = true)
diff --git a/recipes/src/main/java/io/quarkus/updates/core/quarkus37/ChangeMavenCompilerAnnotationProcessorGroupIdAndArtifactId.java b/recipes/src/main/java/io/quarkus/updates/core/quarkus37/ChangeMavenCompilerAnnotationProcessorGroupIdAndArtifactId.java
index 01a76f9..2872793 100644
--- a/recipes/src/main/java/io/quarkus/updates/core/quarkus37/ChangeMavenCompilerAnnotationProcessorGroupIdAndArtifactId.java
+++ b/recipes/src/main/java/io/quarkus/updates/core/quarkus37/ChangeMavenCompilerAnnotationProcessorGroupIdAndArtifactId.java
@@ -1,16 +1,8 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.core.quarkus37;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.NoSuchElementException;
-import java.util.Optional;
+import java.util.*;
-import org.openrewrite.ExecutionContext;
-import org.openrewrite.Option;
-import org.openrewrite.Recipe;
-import org.openrewrite.TreeVisitor;
-import org.openrewrite.Validated;
+import org.openrewrite.*;
import org.openrewrite.internal.lang.Nullable;
import org.openrewrite.maven.MavenDownloadingException;
import org.openrewrite.maven.MavenTagInsertionComparator;
@@ -30,7 +22,7 @@
import lombok.Value;
@Value
-@EqualsAndHashCode(callSuper = true)
+@EqualsAndHashCode(callSuper = false)
public class ChangeMavenCompilerAnnotationProcessorGroupIdAndArtifactId extends Recipe {
@EqualsAndHashCode.Exclude
diff --git a/recipes/src/main/java/io/quarkus/updates/core/quarkus37/SyncMavenCompilerAnnotationProcessorVersion.java b/recipes/src/main/java/io/quarkus/updates/core/quarkus37/SyncMavenCompilerAnnotationProcessorVersion.java
index d1ffba9..0a770f8 100644
--- a/recipes/src/main/java/io/quarkus/updates/core/quarkus37/SyncMavenCompilerAnnotationProcessorVersion.java
+++ b/recipes/src/main/java/io/quarkus/updates/core/quarkus37/SyncMavenCompilerAnnotationProcessorVersion.java
@@ -19,7 +19,7 @@ io.moderne.worker.execution.RecipeMapper
import lombok.Value;
@Value
-@EqualsAndHashCode(callSuper = true)
+@EqualsAndHashCode(callSuper = false)
public class SyncMavenCompilerAnnotationProcessorVersion extends Recipe {
@EqualsAndHashCode.Exclude
diff --git a/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelHttpRecipe.java b/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelHttpRecipe.java
index c0b3517..960010c 100644
--- a/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelHttpRecipe.java
+++ b/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelHttpRecipe.java
@@ -1,7 +1,6 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.camel30.java;
-import lombok.EqualsAndHashCode;
-import lombok.Value;
+import io.quarkus.updates.camel30.AbstractCamelQuarkusJavaVisitor;
import org.openrewrite.ExecutionContext;
import org.openrewrite.Recipe;
@@ -12,11 +11,12 @@
import org.openrewrite.java.ChangeType;
import org.openrewrite.java.JavaTemplate;
import org.openrewrite.java.tree.J;
-
-import io.quarkus.updates.camel30.AbstractCamelQuarkusJavaVisitor;
import org.openrewrite.java.tree.JavaType;
-@EqualsAndHashCode(callSuper = true)
+import lombok.EqualsAndHashCode;
+import lombok.Value;
+
+@EqualsAndHashCode(callSuper = false)
@Value
public class CamelHttpRecipe extends Recipe {
@@ -39,7 +39,7 @@
return new AbstractCamelQuarkusJavaVisitor() {
@Override
- protected J.Import doVisitImport(J.Import _import, ExecutionContext context) {
+ protected J.Import doVisitImport(J.Import _import, ExecutionContext ctx) {
doAfterVisit(
new ChangeType("org.apache.http.HttpHost",
"org.apache.hc.core5.http.HttpHost", true).getVisitor());
@@ -76,12 +76,12 @@
"org.apache.http.conn.ssl.NoopHostnameVerifier",
"org.apache.hc.client5.http.conn.ssl.NoopHostnameVerifier", true).getVisitor());
- return super.doVisitImport(_import, context);
+ return super.doVisitImport(_import, ctx);
}
@Override
- protected J.FieldAccess doVisitFieldAccess(J.FieldAccess fieldAccess, ExecutionContext context) {
- J.FieldAccess f = super.doVisitFieldAccess(fieldAccess, context);
+ protected J.FieldAccess doVisitFieldAccess(J.FieldAccess fieldAccess, ExecutionContext ctx) {
+ J.FieldAccess f = super.doVisitFieldAccess(fieldAccess, ctx);
//The component has been upgraded to use Apache HttpComponents v5
//AuthScope.ANY -> new AuthScope(null, -1)
@@ -97,14 +97,14 @@
}
@Override
- public J.NewClass visitNewClass(J.NewClass newClass, ExecutionContext context) {
- return super.visitNewClass(newClass, context);
+ public J.NewClass visitNewClass(J.NewClass newClass, ExecutionContext ctx) {
+ return super.visitNewClass(newClass, ctx);
}
@Override
- public @Nullable J postVisit(J tree, ExecutionContext context) {
- J j = super.postVisit(tree, context);
+ public @Nullable J postVisit(J tree, ExecutionContext ctx) {
+ J j = super.postVisit(tree, ctx);
//use a new class instead of original element
J.NewClass newClass = getCursor().getMessage("authScopeNewClass");
diff --git a/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelEIPRecipe.java b/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelEIPRecipe.java
index 821922c..47dd2a1 100644
--- a/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelEIPRecipe.java
+++ b/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelEIPRecipe.java
@@ -1,13 +1,13 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.camel30.java;
+import io.quarkus.updates.camel30.AbstractCamelQuarkusJavaVisitor;
+
import org.openrewrite.ExecutionContext;
import org.openrewrite.Recipe;
import org.openrewrite.TreeVisitor;
import org.openrewrite.java.AddImport;
import org.openrewrite.java.tree.J;
-import io.quarkus.updates.camel30.AbstractCamelQuarkusJavaVisitor;
-
public class CamelEIPRecipe extends Recipe {
@Override
@@ -25,8 +25,8 @@
return new AbstractCamelQuarkusJavaVisitor() {
@Override
- protected J.MethodInvocation doVisitMethodInvocation(J.MethodInvocation method, ExecutionContext context) {
- J.MethodInvocation mi = super.doVisitMethodInvocation(method, context);
+ protected J.MethodInvocation doVisitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
+ J.MethodInvocation mi = super.doVisitMethodInvocation(method, ctx);
if (mi.getSimpleName().equals("inOut") || mi.getSimpleName().equals("inOnly")) {
String name = mi.getSimpleName().substring(0, 1).toUpperCase() + mi.getSimpleName().substring(1);
diff --git a/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelAPIsRecipe.java b/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelAPIsRecipe.java
index 45b3f92..2db3972 100644
--- a/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelAPIsRecipe.java
+++ b/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelAPIsRecipe.java
@@ -1,22 +1,14 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.camel30.java;
-import lombok.EqualsAndHashCode;
-import lombok.Value;
+import io.quarkus.updates.camel30.AbstractCamelQuarkusJavaVisitor;
+import io.quarkus.updates.camel30.RecipesUtil;
+import java.beans.SimpleBeanInfo;
+import java.util.*;
+import java.util.regex.Pattern;
-import org.openrewrite.Cursor;
-import org.openrewrite.ExecutionContext;
-import org.openrewrite.Preconditions;
-import org.openrewrite.Recipe;
-import org.openrewrite.Tree;
-import org.openrewrite.TreeVisitor;
+import org.openrewrite.*;
import org.openrewrite.internal.lang.Nullable;
-import org.openrewrite.java.AddImport;
-import org.openrewrite.java.ChangeFieldType;
-import org.openrewrite.java.ChangePackage;
-import org.openrewrite.java.ChangeType;
-import org.openrewrite.java.ImplementInterface;
-import org.openrewrite.java.JavaTemplate;
-import org.openrewrite.java.RemoveImplements;
+import org.openrewrite.java.*;
import org.openrewrite.java.search.UsesMethod;
import org.openrewrite.java.tree.Comment;
import org.openrewrite.java.tree.J;
@@ -25,22 +17,14 @@
import org.openrewrite.java.tree.TypeUtils;
import org.openrewrite.marker.Markers;
-import io.quarkus.updates.camel30.AbstractCamelQuarkusJavaVisitor;
-import io.quarkus.updates.camel30.RecipesUtil;
-
-import java.beans.SimpleBeanInfo;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.Optional;
-import java.util.UUID;
-import java.util.regex.Pattern;
+import lombok.EqualsAndHashCode;
+import lombok.Value;
/**
* Recipe migrating changes between Camel 3.x to 4.x, for more details see the
* <a href="URL#https://camel.apache.org/manual/camel-4-migration-guide.html#_api_changes" >documentation</a>.
*/
-@EqualsAndHashCode(callSuper = true)
+@EqualsAndHashCode(callSuper = false)
@Value
public class CamelAPIsRecipe extends Recipe {
@@ -76,8 +60,8 @@
private Map<UUID, Tree> adaptCache = new HashMap<>();
@Override
- protected J.Import doVisitImport(J.Import _import, ExecutionContext context) {
- J.Import im = super.doVisitImport(_import, context);
+ protected J.Import doVisitImport(J.Import _import, ExecutionContext ctx) {
+ J.Import im = super.doVisitImport(_import, ctx);
//Removed Discard and DiscardOldest from org.apache.camel.util.concurrent.ThreadPoolRejectedPolicy.
if(im.isStatic() && im.getTypeName().equals("org.apache.camel.util.concurrent.ThreadPoolRejectedPolicy")
@@ -109,8 +93,8 @@
}
@Override
- protected J.ClassDeclaration doVisitClassDeclaration(J.ClassDeclaration classDecl, ExecutionContext context) {
- J.ClassDeclaration cd = super.doVisitClassDeclaration(classDecl, context);
+ protected J.ClassDeclaration doVisitClassDeclaration(J.ClassDeclaration classDecl, ExecutionContext ctx) {
+ J.ClassDeclaration cd = super.doVisitClassDeclaration(classDecl, ctx);
//Removed org.apache.camel.spi.OnCamelContextStart. Use org.apache.camel.spi.OnCamelContextStarting instead.
if(cd.getImplements() != null && cd.getImplements().stream()
@@ -133,11 +117,11 @@
}
@Override
- protected J.FieldAccess doVisitFieldAccess(J.FieldAccess fieldAccess, ExecutionContext context) {
- J.FieldAccess fa = super.doVisitFieldAccess(fieldAccess, context);
+ protected J.FieldAccess doVisitFieldAccess(J.FieldAccess fieldAccess, ExecutionContext ctx) {
+ J.FieldAccess fa = super.doVisitFieldAccess(fieldAccess, ctx);
//The org.apache.camel.ExchangePattern has removed InOptionalOut.
if("InOptionalOut".equals(fieldAccess.getSimpleName()) && fa.getType() != null && fa.getType().isAssignableFrom(Pattern.compile("org.apache.camel.ExchangePattern"))) {
- return fa.withName(new J.Identifier(UUID.randomUUID(), fa.getPrefix(), Markers.EMPTY, "/* " + fa.getSimpleName() + " has been removed */", fa.getType(), null));
+ return fa.withName(new J.Identifier(Tree.randomId(), fa.getPrefix(), Markers.EMPTY, "/* " + fa.getSimpleName() + " has been removed */", fa.getType(), null));
}
else if(("Discard".equals(fa.getSimpleName()) || "DiscardOldest".equals(fa.getSimpleName()))
@@ -153,8 +137,8 @@
}
@Override
- protected J.MethodDeclaration doVisitMethodDeclaration(J.MethodDeclaration method, ExecutionContext context) {
- J.MethodDeclaration md = super.doVisitMethodDeclaration(method, context);
+ protected J.MethodDeclaration doVisitMethodDeclaration(J.MethodDeclaration method, ExecutionContext ctx) {
+ J.MethodDeclaration md = super.doVisitMethodDeclaration(method, ctx);
//Method 'configure' was removed from `org.apache.camel.main.MainListener`, consider using 'beforeConfigure' or 'afterConfigure'.
if("configure".equals(md.getSimpleName())
@@ -172,8 +156,8 @@
}
@Override
- protected J.Annotation doVisitAnnotation(J.Annotation annotation, ExecutionContext context) {
- J.Annotation a = super.doVisitAnnotation(annotation, context);
+ protected J.Annotation doVisitAnnotation(J.Annotation annotation, ExecutionContext ctx) {
+ J.Annotation a = super.doVisitAnnotation(annotation, ctx);
//Removed @FallbackConverter as you should use @Converter(fallback = true) instead.
if (a.getType().toString().equals("org.apache.camel.FallbackConverter")) {
@@ -228,8 +212,8 @@
}
@Override
- protected J.MethodInvocation doVisitMethodInvocation(J.MethodInvocation method, ExecutionContext context) {
- J.MethodInvocation mi = super.doVisitMethodInvocation(method, context);
+ protected J.MethodInvocation doVisitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
+ J.MethodInvocation mi = super.doVisitMethodInvocation(method, ctx);
//if adapt method invocation is used as a select for another method invocation, it is replaced
if(mi.getSelect() != null && adaptCache.containsKey(mi.getSelect().getId())) {
@@ -237,7 +221,7 @@
} else
// context.getExtension(ExtendedCamelContext.class).getComponentNameResolver() -> PluginHelper.getComponentNameResolver(context)
if (getMethodMatcher(MATCHER_CONTEXT_GET_ENDPOINT_MAP).matches(mi, false)) {
- mi = mi.withName(new J.Identifier(UUID.randomUUID(), mi.getPrefix(), Markers.EMPTY,
+ mi = mi.withName(new J.Identifier(Tree.randomId(), mi.getPrefix(), Markers.EMPTY,
"/* " + mi.getSimpleName() + " has been removed, consider getEndpointRegistry() instead */", mi.getType(), null));
}
// ProducerTemplate.asyncCallback() has been replaced by 'asyncSend(') or 'asyncRequest()'
@@ -321,8 +305,8 @@
}
@Override
- public @Nullable J postVisit(J tree, ExecutionContext context) {
- J j = super.postVisit(tree, context);
+ public @Nullable J postVisit(J tree, ExecutionContext ctx) {
+ J j = super.postVisit(tree, ctx);
UUID adaptCast = getCursor().getMessage("adapt_cast");
@@ -330,8 +314,7 @@
J.MethodInvocation mi = (J.MethodInvocation)j;
J.ControlParentheses cp = (J.ControlParentheses) adaptCache.get(adaptCast);
- J.MethodInvocation m = mi.withSelect(cp);
- return m;
+ return mi.withSelect(cp);
}
J removeTypeCast = getCursor().getMessage("remove_type_cast");
diff --git a/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelBeanRecipe.java b/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelBeanRecipe.java
index f86882e..9ceb78d 100644
--- a/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelBeanRecipe.java
+++ b/recipes/src/main/java/io/quarkus/updates/camel30/java/CamelBeanRecipe.java
@@ -1,5 +1,6 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.camel30.java;
+import io.quarkus.updates.camel30.AbstractCamelQuarkusJavaVisitor;
import java.util.Arrays;
import java.util.List;
import java.util.regex.Matcher;
@@ -13,8 +14,6 @@
import org.openrewrite.java.tree.Expression;
import org.openrewrite.java.tree.J;
-import io.quarkus.updates.camel30.AbstractCamelQuarkusJavaVisitor;
-
public class CamelBeanRecipe extends Recipe {
private final String primitive[] = new String[] { "byte", "short", "int", "float", "double", "long", "char",
@@ -35,8 +34,8 @@
return new AbstractCamelQuarkusJavaVisitor() {
@Override
- protected J.MethodInvocation doVisitMethodInvocation(J.MethodInvocation method, ExecutionContext context) {
- J.MethodInvocation mi = super.doVisitMethodInvocation(method, context);
+ protected J.MethodInvocation doVisitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
+ J.MethodInvocation mi = super.doVisitMethodInvocation(method, ctx);
Pattern findMethodPattern = Pattern.compile("method=.*");
if (mi.getSimpleName().equals("to")) {
@@ -95,8 +94,7 @@
// Check if the string matches the method call pattern
if (matcher.matches()) {
// Extract the method name from the matched group
- String methodName = matcher.group(1);
- return methodName;
+ return matcher.group(1);
} else {
// Return null if the string doesn't match the method call pattern
return null;
@@ -109,7 +107,7 @@
Pattern fullyQualifiedPattern = Pattern
.compile("^([a-zA-Z_$][a-zA-Z0-9_$]*\\.)*[a-zA-Z_$][a-zA-Z0-9_$]*$");
- String updatedArgs = Arrays.asList(argument.split(",")).stream().map(arg -> {
+ return Arrays.asList(argument.split(",")).stream().map(arg -> {
if (arg.endsWith(".class")) {
return arg;
}
@@ -136,8 +134,6 @@
}).collect(Collectors.joining(","));
- return updatedArgs;
-
}
}
diff --git a/recipes/src/main/java/io/quarkus/updates/camel30/xml/CircuitBreakerXmlDslRecipe.java b/recipes/src/main/java/io/quarkus/updates/camel30/xml/CircuitBreakerXmlDslRecipe.java
index 79f0ec2..2441b78 100644
--- a/recipes/src/main/java/io/quarkus/updates/camel30/xml/CircuitBreakerXmlDslRecipe.java
+++ b/recipes/src/main/java/io/quarkus/updates/camel30/xml/CircuitBreakerXmlDslRecipe.java
@@ -1,5 +1,9 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.camel30.xml;
+import java.util.*;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
import org.openrewrite.ExecutionContext;
import org.openrewrite.Recipe;
import org.openrewrite.Tree;
@@ -10,14 +14,6 @@
import org.openrewrite.xml.XmlIsoVisitor;
import org.openrewrite.xml.tree.Xml;
-import java.util.Arrays;
-import java.util.LinkedHashMap;
-import java.util.LinkedHashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.stream.Collectors;
-import java.util.stream.Stream;
-
/**
* <p>
* <a:href link="https://camel.apache.org/manual/camel-4-migration-guide.html#_circuitbreaker_eip" >Camel Migration guide</a:href>
diff --git a/recipes/src/main/java/io/quarkus/updates/camel30/yaml/CamelQuarkusYamlStepsInFromRecipe.java b/recipes/src/main/java/io/quarkus/updates/camel30/yaml/CamelQuarkusYamlStepsInFromRecipe.java
index 5d3a7b2..26fcdaa 100644
--- a/recipes/src/main/java/io/quarkus/updates/camel30/yaml/CamelQuarkusYamlStepsInFromRecipe.java
+++ b/recipes/src/main/java/io/quarkus/updates/camel30/yaml/CamelQuarkusYamlStepsInFromRecipe.java
@@ -1,7 +1,8 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.camel30.yaml;
-import lombok.EqualsAndHashCode;
-import lombok.Value;
+import java.util.ArrayList;
+import java.util.List;
+
import org.openrewrite.ExecutionContext;
import org.openrewrite.Recipe;
import org.openrewrite.TreeVisitor;
@@ -11,8 +12,8 @@
import org.openrewrite.yaml.style.IndentsStyle;
import org.openrewrite.yaml.tree.Yaml;
-import java.util.ArrayList;
-import java.util.List;
+import lombok.EqualsAndHashCode;
+import lombok.Value;
/**
* Fixes following yaml change.
@@ -37,7 +38,7 @@
* - log: "message"
* </pre>
*/
-@EqualsAndHashCode(callSuper = true)
+@EqualsAndHashCode(callSuper = false)
@Value
public class CamelQuarkusYamlStepsInFromRecipe extends Recipe {
@@ -67,8 +68,8 @@
Yaml.Mapping.Entry steps = null;
@Override
- public Yaml.Mapping.Entry visitMappingEntry(Yaml.Mapping.Entry entry, ExecutionContext context) {
- Yaml.Mapping.Entry e = super.visitMappingEntry(entry, context);
+ public Yaml.Mapping.Entry visitMappingEntry(Yaml.Mapping.Entry entry, ExecutionContext ctx) {
+ Yaml.Mapping.Entry e = super.visitMappingEntry(entry, ctx);
if(steps == null && (MATCHER_WITH_ROUTE.matches(getCursor()) || MATCHER_WITHOUT_ROUTE.matches(getCursor()))) {
steps = e;
@@ -82,8 +83,8 @@
}
@Override
- public Yaml.Mapping visitMapping(Yaml.Mapping mapping, ExecutionContext context) {
- Yaml.Mapping m = super.visitMapping(mapping, context);
+ public Yaml.Mapping visitMapping(Yaml.Mapping mapping, ExecutionContext ctx) {
+ Yaml.Mapping m = super.visitMapping(mapping, ctx);
String prop = YamlRecipesUtil.getProperty(getCursor());
if(("route.from".equals(prop) || "from".equals(prop)) && from == null) {
@@ -100,8 +101,8 @@
doAfterVisit(new YamlIsoVisitor<ExecutionContext>() {
@Override
- public Yaml.Mapping visitMapping(Yaml.Mapping mapping, ExecutionContext c) {
- Yaml.Mapping m = super.visitMapping(mapping, c);
+ public Yaml.Mapping visitMapping(Yaml.Mapping mapping, ExecutionContext ctx) {
+ Yaml.Mapping m = super.visitMapping(mapping, ctx);
if(m == from) {
List<Yaml.Mapping.Entry> entries = new ArrayList<>(m.getEntries());
diff --git a/recipes/src/main/java/io/quarkus/updates/camel30/yaml/CamelQuarkusYamlRouteConfigurationSequenceRecipe.java b/recipes/src/main/java/io/quarkus/updates/camel30/yaml/CamelQuarkusYamlRouteConfigurationSequenceRecipe.java
index 551419e..a2a43b8 100644
--- a/recipes/src/main/java/io/quarkus/updates/camel30/yaml/CamelQuarkusYamlRouteConfigurationSequenceRecipe.java
+++ b/recipes/src/main/java/io/quarkus/updates/camel30/yaml/CamelQuarkusYamlRouteConfigurationSequenceRecipe.java
@@ -1,7 +1,11 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.camel30.yaml;
-import lombok.EqualsAndHashCode;
-import lombok.Value;
+import static org.openrewrite.Tree.randomId;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+
import org.openrewrite.ExecutionContext;
import org.openrewrite.Recipe;
import org.openrewrite.TreeVisitor;
@@ -10,17 +14,14 @@
import org.openrewrite.yaml.style.IndentsStyle;
import org.openrewrite.yaml.tree.Yaml;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.stream.Collectors;
-
-import static org.openrewrite.Tree.randomId;
+import lombok.EqualsAndHashCode;
+import lombok.Value;
/**
* Camel API changes requires several changes in YAML route definition.
* Route-configuration children sequence is replaced with mappingEntry (with special migration of "on-exception")
*/
-@EqualsAndHashCode(callSuper = true)
+@EqualsAndHashCode(callSuper = false)
@Value
public class CamelQuarkusYamlRouteConfigurationSequenceRecipe extends Recipe {
@@ -52,8 +53,8 @@
}
@Override
- public Yaml.Sequence visitSequence(Yaml.Sequence sequence, ExecutionContext context) {
- Yaml.Sequence s = super.visitSequence(sequence, context);
+ public Yaml.Sequence visitSequence(Yaml.Sequence sequence, ExecutionContext ctx) {
+ Yaml.Sequence s = super.visitSequence(sequence, ctx);
//if there is a sequence in a route-configuration, it has to be replaced with mapping
if (new JsonPathMatcher("$.route-configuration").matches(getCursor().getParent())) {
@@ -63,8 +64,8 @@
}
@Override
- public Yaml.Mapping.Entry visitMappingEntry(Yaml.Mapping.Entry entry, ExecutionContext context) {
- Yaml.Mapping.Entry e = super.visitMappingEntry(entry, context);
+ public Yaml.Mapping.Entry visitMappingEntry(Yaml.Mapping.Entry entry, ExecutionContext ctx) {
+ Yaml.Mapping.Entry e = super.visitMappingEntry(entry, ctx);
//if current mapping contains an entry with sequence belonging to route-configuration, remove the sequence
if (e.getValue() == sequenceToReplace) {
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate37Test.java b/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate37Test.java
index baa112f..67eb50e 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate37Test.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate37Test.java
@@ -3,14 +3,15 @@ io.moderne.worker.execution.RecipeMapper
import static org.openrewrite.maven.Assertions.pomXml;
import java.nio.file.Path;
-
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-public class CoreUpdate37Test implements RewriteTest {
+class CoreUpdate37Test implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -19,10 +20,12 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testMavenCompilerJavaVersion() {
+ void mavenCompilerJavaVersion() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -50,7 +53,8 @@
"""));
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -66,9 +70,10 @@
}
@Test
- void testMavenPluginUpdates() {
+ void mavenPluginUpdates() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -159,9 +164,10 @@
}
@Test
- void testMavenPluginUpdatesDefaultGroupId() {
+ void mavenPluginUpdatesDefaultGroupId() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -248,9 +254,10 @@
}
@Test
- void testJpaModelgenNoChanges() {
+ void jpaModelgenNoChanges() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -270,9 +277,10 @@
}
@Test
- void testJpaModelgenOldDependency() {
+ void jpaModelgenOldDependency() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -324,9 +332,10 @@
}
@Test
- void testJpaModelgenNewDependency() {
+ void jpaModelgenNewDependency() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -379,9 +388,10 @@
}
@Test
- void testJpaModelgenNewDependencyManagedByQuarkusBom() {
+ void jpaModelgenNewDependencyManagedByQuarkusBom() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -457,9 +467,10 @@
}
@Test
- void testJpaModelgenExistingConfig() {
+ void jpaModelgenExistingConfig() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -515,9 +526,10 @@
}
@Test
- void testJpaModelgenAnotherProcessor() {
+ void jpaModelgenAnotherProcessor() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -583,9 +595,10 @@
}
@Test
- void testJpaModelgenAnnotationProcessorAlreadyPresent() {
+ void jpaModelgenAnnotationProcessorAlreadyPresent() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -645,9 +658,10 @@
}
@Test
- void testJpaModelgenOldJpaModelgenAnnotationProcessorAlreadyPresent() {
+ void jpaModelgenOldJpaModelgenAnnotationProcessorAlreadyPresent() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -730,9 +744,10 @@
}
@Test
- void testJpaModelgenOldJpaModelgenAnnotationProcessorAlreadyPresentWithOutdatedVersion() {
+ void jpaModelgenOldJpaModelgenAnnotationProcessorAlreadyPresentWithOutdatedVersion() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -816,9 +831,10 @@
}
@Test
- void testSyncVersion() {
+ void syncVersion() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
@@ -901,9 +917,10 @@
}
@Test
- void testResteasyClientRenaming() {
+ void resteasyClientRenaming() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate39Test.java b/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate39Test.java
index 58dada6..69a0dff 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate39Test.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate39Test.java
@@ -3,14 +3,15 @@ io.moderne.worker.execution.RecipeMapper
import static org.openrewrite.maven.Assertions.pomXml;
import java.nio.file.Path;
-
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-public class CoreUpdate39Test implements RewriteTest {
+class CoreUpdate39Test implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -19,10 +20,12 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testPanacheAnnotationProcessorRemoved() {
+ void panacheAnnotationProcessorRemoved() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate30Test.java b/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate30Test.java
index 47a9a3f..74c30fc 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate30Test.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate30Test.java
@@ -3,14 +3,15 @@ io.moderne.worker.execution.RecipeMapper
import static org.openrewrite.java.Assertions.java;
import java.nio.file.Path;
-
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-public class CoreUpdate30Test implements RewriteTest {
+class CoreUpdate30Test implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -19,31 +20,32 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testExtensionUpdate() {
+ void extensionUpdate() {
//language=java
rewriteRun(java(
"""
- package io.quarkiverse.githubapp.deployment;
+ package io.quarkiverse.githubapp.deployment;
- import javax.enterprise.event.Event;
- import javax.enterprise.util.AnnotationLiteral;
- import javax.inject.Inject;
- import javax.inject.Singleton;
+ import javax.enterprise.event.Event;
+ import javax.enterprise.util.AnnotationLiteral;
+ import javax.inject.Inject;
+ import javax.inject.Singleton;
- class GitHubAppProcessor {
- }
+ class GitHubAppProcessor {
+ }
""",
"""
- package io.quarkiverse.githubapp.deployment;
+ package io.quarkiverse.githubapp.deployment;
- import jakarta.enterprise.event.Event;
- import jakarta.enterprise.util.AnnotationLiteral;
- import jakarta.inject.Inject;
- import jakarta.inject.Singleton;
+ import jakarta.enterprise.event.Event;
+ import jakarta.enterprise.util.AnnotationLiteral;
+ import jakarta.inject.Inject;
+ import jakarta.inject.Singleton;
- class GitHubAppProcessor {
- }
+ class GitHubAppProcessor {
+ }
"""));
}
}
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate33Test.java b/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate33Test.java
index 46a2aa7..02a5ab9 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate33Test.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/core/CoreUpdate33Test.java
@@ -3,14 +3,15 @@ io.moderne.worker.execution.RecipeMapper
import static org.openrewrite.maven.Assertions.pomXml;
import java.nio.file.Path;
-
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-public class CoreUpdate33Test implements RewriteTest {
+class CoreUpdate33Test implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -19,10 +20,12 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testGraalVMSDK() {
+ void graalVMSDK() {
//language=xml
- rewriteRun(pomXml("""
+ rewriteRun(pomXml(
+ """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>io.quarkus.bot</groupId>
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/core/CoreTestUtil.java b/recipes-tests/src/test/java/io/quarkus/updates/core/CoreTestUtil.java
index 56941e6..f0afda1 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/core/CoreTestUtil.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/core/CoreTestUtil.java
@@ -15,8 +15,8 @@ io.moderne.worker.execution.RecipeMapper
import org.openrewrite.config.CompositeRecipe;
import org.openrewrite.config.Environment;
import org.openrewrite.config.YamlResourceLoader;
-import org.openrewrite.maven.UpgradeDependencyVersion;
import org.openrewrite.maven.ChangePropertyValue;
+import org.openrewrite.maven.UpgradeDependencyVersion;
import org.openrewrite.test.RecipeSpec;
public final class CoreTestUtil {
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelJmxTest.java b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelJmxTest.java
index 791f841..7f43f6e 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelJmxTest.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelJmxTest.java
@@ -1,14 +1,16 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.camel30;
+import static org.openrewrite.java.Assertions.java;
+
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-import static org.openrewrite.java.Assertions.java;
-
-public class CamelJmxTest implements RewriteTest {
+class CamelJmxTest implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -18,37 +20,38 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testRenamedMethods() {
+ void renamedMethods() {
//language=java
rewriteRun(java(
"""
- import org.apache.camel.api.management.mbean.ManagedChoiceMBean;
- import org.apache.camel.api.management.mbean.ManagedFailoverLoadBalancerMBean;
+ import org.apache.camel.api.management.mbean.ManagedChoiceMBean;
+ import org.apache.camel.api.management.mbean.ManagedFailoverLoadBalancerMBean;
- public class Test {
+ public class Test {
- void test() {
- ManagedChoiceMBean mbean = null;
- mbean.choiceStatistics();
- ManagedFailoverLoadBalancerMBean mbean2 = null;
- mbean2.exceptionStatistics();
- }
+ void test() {
+ ManagedChoiceMBean mbean = null;
+ mbean.choiceStatistics();
+ ManagedFailoverLoadBalancerMBean mbean2 = null;
+ mbean2.exceptionStatistics();
}
+ }
""",
"""
- import org.apache.camel.api.management.mbean.ManagedChoiceMBean;
- import org.apache.camel.api.management.mbean.ManagedFailoverLoadBalancerMBean;
+ import org.apache.camel.api.management.mbean.ManagedChoiceMBean;
+ import org.apache.camel.api.management.mbean.ManagedFailoverLoadBalancerMBean;
- public class Test {
+ public class Test {
- void test() {
- ManagedChoiceMBean mbean = null;
- mbean.extendedInformation();
- ManagedFailoverLoadBalancerMBean mbean2 = null;
- mbean2.extendedInformation();
- }
+ void test() {
+ ManagedChoiceMBean mbean = null;
+ mbean.extendedInformation();
+ ManagedFailoverLoadBalancerMBean mbean2 = null;
+ mbean2.extendedInformation();
}
+ }
"""));
}
}
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelAPIsTest.java b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelAPIsTest.java
index 9d087b8..e6f169c 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelAPIsTest.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelAPIsTest.java
@@ -3,12 +3,14 @@ io.moderne.worker.execution.RecipeMapper
import static org.openrewrite.java.Assertions.java;
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-public class CamelAPIsTest implements RewriteTest {
+class CamelAPIsTest implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -18,26 +20,28 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testRemovedExchangePatternInOptionalOut() {
+ void removedExchangePatternInOptionalOut() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.ExchangePattern;
- import org.apache.camel.builder.RouteBuilder;
+ rewriteRun(java(
+ """
+ import org.apache.camel.ExchangePattern;
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
+ @Override
+ public void configure() {
- String uri = "log:c";
+ String uri = "log:c";
- from("direct:start")
- .toD("log:a", true)
- .to(ExchangePattern.InOptionalOut, "log:b")
- .to(uri);
- }
+ from("direct:start")
+ .toD("log:a", true)
+ .to(ExchangePattern.InOptionalOut, "log:b")
+ .to(uri);
}
+ }
""", """
import org.apache.camel.ExchangePattern;
import org.apache.camel.builder.RouteBuilder;
@@ -59,24 +63,25 @@
}
@Test
- void testRemovedFullyExchangePatternInOptionalOut() {
+ void removedFullyExchangePatternInOptionalOut() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.builder.RouteBuilder;
+ rewriteRun(java(
+ """
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
+ @Override
+ public void configure() {
- String uri = "log:c";
+ String uri = "log:c";
- from("direct:start")
- .toD("log:a", true)
- .to(org.apache.camel.ExchangePattern.InOptionalOut, "log:b")
- .to(uri);
- }
+ from("direct:start")
+ .toD("log:a", true)
+ .to(org.apache.camel.ExchangePattern.InOptionalOut, "log:b")
+ .to(uri);
}
+ }
""", """
import org.apache.camel.builder.RouteBuilder;
@@ -97,19 +102,20 @@
}
@Test
- void testComponentNameResolver() {
+ void componentNameResolver() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.CamelContext;
+ rewriteRun(java(
+ """
+ import org.apache.camel.CamelContext;
- public class Test {
+ public class Test {
- CamelContext context;
+ CamelContext context;
- public void test() {
- context.getEndpointMap().containsKey("bar://order");
- }
+ public void test() {
+ context.getEndpointMap().containsKey("bar://order");
}
+ }
""",
"""
import org.apache.camel.CamelContext;
@@ -126,17 +132,18 @@
}
@Test
- void testFallbackConverterOnMethod() {
+ void fallbackConverterOnMethod() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.FallbackConverter;
+ rewriteRun(java(
+ """
+ import org.apache.camel.FallbackConverter;
- public class Test {
+ public class Test {
- @FallbackConverter
- public void test() {
- }
+ @FallbackConverter
+ public void test() {
}
+ }
""", """
import org.apache.camel.Converter;
@@ -150,14 +157,15 @@
}
@Test
- void testFallbackConverterOnClassDef() {
+ void fallbackConverterOnClassDef() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.FallbackConverter;
+ rewriteRun(java(
+ """
+ import org.apache.camel.FallbackConverter;
- @FallbackConverter
- public class Test {
- }
+ @FallbackConverter
+ public class Test {
+ }
""", """
import org.apache.camel.Converter;
@@ -168,89 +176,93 @@
}
@Test
- void testEndpointInject() {
+ void endpointInject() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.component.mock.MockEndpoint;
- import org.apache.camel.EndpointInject;
+ rewriteRun(java(
+ """
+ import org.apache.camel.component.mock.MockEndpoint;
+ import org.apache.camel.EndpointInject;
- public class Test {
+ public class Test {
- @EndpointInject(uri = "mock:out")
- private MockEndpoint endpoint;
- }
+ @EndpointInject(uri = "mock:out")
+ private MockEndpoint endpoint;
+ }
""", """
- import org.apache.camel.component.mock.MockEndpoint;
- import org.apache.camel.EndpointInject;
+ import org.apache.camel.component.mock.MockEndpoint;
+ import org.apache.camel.EndpointInject;
- public class Test {
+ public class Test {
- @EndpointInject("mock:out")
- private MockEndpoint endpoint;
- }
+ @EndpointInject("mock:out")
+ private MockEndpoint endpoint;
+ }
"""));
}
@Test
- void testProduce() {
+ void produce() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.component.mock.MockEndpoint;
- import org.apache.camel.Produce;
+ rewriteRun(java(
+ """
+ import org.apache.camel.component.mock.MockEndpoint;
+ import org.apache.camel.Produce;
- public class Test {
+ public class Test {
- @Produce(uri = "test")
- private MockEndpoint endpoint() {
- return null;
- }
- }
+ @Produce(uri = "test")
+ private MockEndpoint endpoint() {
+ return null;
+ }
+ }
""", """
- import org.apache.camel.component.mock.MockEndpoint;
- import org.apache.camel.Produce;
+ import org.apache.camel.component.mock.MockEndpoint;
+ import org.apache.camel.Produce;
- public class Test {
+ public class Test {
- @Produce("test")
- private MockEndpoint endpoint() {
- return null;
- }
- }
+ @Produce("test")
+ private MockEndpoint endpoint() {
+ return null;
+ }
+ }
"""));
}
@Test
- void testConsume() {
+ void consume() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.component.mock.MockEndpoint;
- import org.apache.camel.Consume;
+ rewriteRun(java(
+ """
+ import org.apache.camel.component.mock.MockEndpoint;
+ import org.apache.camel.Consume;
- public class Test {
+ public class Test {
- @Consume(uri = "test")
- private MockEndpoint endpoint() {
- return null;
- }
- }
+ @Consume(uri = "test")
+ private MockEndpoint endpoint() {
+ return null;
+ }
+ }
""", """
- import org.apache.camel.component.mock.MockEndpoint;
- import org.apache.camel.Consume;
+ import org.apache.camel.component.mock.MockEndpoint;
+ import org.apache.camel.Consume;
- public class Test {
+ public class Test {
- @Consume("test")
- private MockEndpoint endpoint() {
- return null;
- }
- }
+ @Consume("test")
+ private MockEndpoint endpoint() {
+ return null;
+ }
+ }
"""));
}
@Test
- void testUriEndpoint() {
+ void uriEndpoint() {
//language=java
- rewriteRun(java("""
+ rewriteRun(java(
+ """
import org.apache.camel.spi.UriEndpoint;
import org.apache.camel.support.DefaultEndpoint;
@@ -269,9 +281,10 @@
}
@Test
- void testUriEndpointWithUnknownValue() {
+ void uriEndpointWithUnknownValue() {
//language=java
- rewriteRun(java("""
+ rewriteRun(java(
+ """
import org.apache.camel.spi.UriEndpoint;
import org.apache.camel.support.DefaultEndpoint;
@@ -291,9 +304,10 @@
}
@Test
- void testAsyncCallback() {
+ void asyncCallback() {
//language=java
- rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java("""
+ rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java(
+ """
import org.apache.camel.ProducerTemplate;
import org.apache.camel.Exchange;
@@ -328,9 +342,10 @@
}
@Test
- void testOnCamelContextStart() {
+ void onCamelContextStart() {
//language=java
- rewriteRun(java("""
+ rewriteRun(java(
+ """
import org.apache.camel.spi.OnCamelContextStart;
import org.apache.camel.CamelContext;
@@ -350,9 +365,10 @@
}
@Test
- void testOnCamelContextStop() {
+ void onCamelContextStop() {
//language=java
- rewriteRun(java("""
+ rewriteRun(java(
+ """
import org.apache.camel.spi.OnCamelContextStop;
import org.apache.camel.CamelContext;
@@ -372,20 +388,21 @@
}
@Test
- void testAdapt() {
+ void adapt() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.CamelContext;
- import org.apache.camel.model.ModelCamelContext;
+ rewriteRun(java(
+ """
+ import org.apache.camel.CamelContext;
+ import org.apache.camel.model.ModelCamelContext;
- public class Test {
+ public class Test {
- CamelContext context;
+ CamelContext context;
- public void test() {
- context.adapt(ModelCamelContext.class).getRouteDefinition("forMocking");
- }
+ public void test() {
+ context.adapt(ModelCamelContext.class).getRouteDefinition("forMocking");
}
+ }
""", """
import org.apache.camel.CamelContext;
import org.apache.camel.model.ModelCamelContext;
@@ -402,23 +419,24 @@
}
@Test
- void testMoreOccurrencesAdapt() {
+ void moreOccurrencesAdapt() {
//language=java
- rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java("""
- import org.apache.camel.CamelContext;
- import org.apache.camel.model.ModelCamelContext;
+ rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java(
+ """
+ import org.apache.camel.CamelContext;
+ import org.apache.camel.model.ModelCamelContext;
- public class Test {
+ public class Test {
- CamelContext context, c1, c2, c3;
+ CamelContext context, c1, c2, c3;
- public ModelCamelContext test() {
- context.adapt(ModelCamelContext.class).getRouteDefinition("forMocking");
- c1.adapt(ModelCamelContext.class).getRegistry();
- c2.adapt(ModelCamelContext.class);
- return c3.adapt(ModelCamelContext.class);
- }
+ public ModelCamelContext test() {
+ context.adapt(ModelCamelContext.class).getRouteDefinition("forMocking");
+ c1.adapt(ModelCamelContext.class).getRegistry();
+ c2.adapt(ModelCamelContext.class);
+ return c3.adapt(ModelCamelContext.class);
}
+ }
""", """
import org.apache.camel.CamelContext;
import org.apache.camel.model.ModelCamelContext;
@@ -438,21 +456,22 @@
}
@Test
- void testAdaptStandalone() {
+ void adaptStandalone() {
//language=java
- rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java("""
- import org.apache.camel.CamelContext;
- import org.apache.camel.model.ModelCamelContext;
+ rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java(
+ """
+ import org.apache.camel.CamelContext;
+ import org.apache.camel.model.ModelCamelContext;
- public class Test {
+ public class Test {
- CamelContext context;
+ CamelContext context;
- public void test() {
+ public void test() {
- context.adapt(ModelCamelContext.class);
- }
+ context.adapt(ModelCamelContext.class);
}
+ }
""", """
import org.apache.camel.CamelContext;
import org.apache.camel.model.ModelCamelContext;
@@ -470,9 +489,10 @@
}
@Test
- void testAdapt2() {
+ void adapt2() {
//language=java
- rewriteRun(java("""
+ rewriteRun(java(
+ """
package org.apache.camel.quarkus.component.test.it;
import org.apache.camel.CamelContext;
@@ -505,23 +525,24 @@
}
@Test
- void testComponenetNameResolverViaPluginHelper() {
+ void componenetNameResolverViaPluginHelper() {
//language=java
- rewriteRun(java("""
- package org.apache.camel.quarkus.component.test.it;
+ rewriteRun(java(
+ """
+ package org.apache.camel.quarkus.component.test.it;
- import org.apache.camel.CamelContext;
- import org.apache.camel.ExtendedCamelContext;
- import org.apache.camel.spi.ComponentNameResolver;
+ import org.apache.camel.CamelContext;
+ import org.apache.camel.ExtendedCamelContext;
+ import org.apache.camel.spi.ComponentNameResolver;
- public class Test {
+ public class Test {
- CamelContext context;
+ CamelContext context;
- public void test() {
- ComponentNameResolver ec = context.getExtension(ExtendedCamelContext.class).getComponentNameResolver();
- }
+ public void test() {
+ ComponentNameResolver ec = context.getExtension(ExtendedCamelContext.class).getComponentNameResolver();
}
+ }
""",
"""
package org.apache.camel.quarkus.component.test.it;
@@ -543,23 +564,23 @@
}
@Test
- void testRuntimeCatalog() {
+ void runtimeCatalog() {
//language=java
rewriteRun(java(
"""
- package org.apache.camel.quarkus.component.test.it;
+ package org.apache.camel.quarkus.component.test.it;
- import org.apache.camel.CamelContext;
- import org.apache.camel.catalog.RuntimeCamelCatalog;
+ import org.apache.camel.CamelContext;
+ import org.apache.camel.catalog.RuntimeCamelCatalog;
- public class Test {
+ public class Test {
- CamelContext context;
+ CamelContext context;
- public void test() {
- final CamelRuntimeCatalog catalog = (CamelRuntimeCatalog) context.getExtension(RuntimeCamelCatalog.class);
- }
+ public void test() {
+ final CamelRuntimeCatalog catalog = (CamelRuntimeCatalog) context.getExtension(RuntimeCamelCatalog.class);
}
+ }
""",
"""
package org.apache.camel.quarkus.component.test.it;
@@ -579,7 +600,7 @@
}
@Test
- void testAdaptRouteDefinition() {
+ void adaptRouteDefinition() {
//language=java
rewriteRun(java(
"""
@@ -617,9 +638,10 @@
}
@Test
- void testDecoupleExtendedCamelContext() {
+ void decoupleExtendedCamelContext() {
//language=java
- rewriteRun(java("""
+ rewriteRun(java(
+ """
import org.apache.camel.CamelContext;
import org.apache.camel.ExtendedCamelContext;
@@ -650,9 +672,10 @@
}
@Test
- void testDecoupleExtendedExchange() {
+ void decoupleExtendedExchange() {
//language=java
- rewriteRun(java("""
+ rewriteRun(java(
+ """
import org.apache.camel.Exchange;
import org.apache.camel.ExtendedExchange;
import org.apache.camel.spi.Synchronization;
@@ -685,9 +708,10 @@
}
@Test
- void testDecoupleExtendedExchange2() {
+ void decoupleExtendedExchange2() {
//language=java
- rewriteRun(java("""
+ rewriteRun(java(
+ """
import org.apache.camel.CamelContext;
import org.apache.camel.catalog.RuntimeCamelCatalog;
@@ -716,9 +740,10 @@
}
@Test
- void testExchangeIsFailureHandled() {
+ void exchangeIsFailureHandled() {
//language=java
- rewriteRun(java("""
+ rewriteRun(java(
+ """
import org.apache.camel.Exchange;
import org.apache.camel.ExchangePropertyKey;
@@ -749,9 +774,10 @@
}
@Test
- void testThreadPoolRejectedPolicy() {
+ void threadPoolRejectedPolicy() {
//language=java
- rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java("""
+ rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java(
+ """
import org.apache.camel.util.concurrent.ThreadPoolRejectedPolicy;
import static org.apache.camel.util.concurrent.ThreadPoolRejectedPolicy.Discard;
@@ -786,18 +812,19 @@
}
@Test
- void testSimpleBuilder() {
+ void simpleBuilder() {
//language=java
- rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java("""
+ rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java(
+ """
import org.apache.camel.builder.SimpleBuilder;
""",
"""
- /*'java.beans.SimpleBeanInfo' has been removed, (class was used internally).*/import org.apache.camel.builder.SimpleBuilder;
+ /*'java.beans.SimpleBeanInfo' has been removed, (class was used internally).*/import org.apache.camel.builder.SimpleBuilder;
"""));
}
@Test
- void testOneIntrospectionSupport() {
+ void oneIntrospectionSupport() {
//language=java
rewriteRun(spec -> CamelQuarkusTestUtil.recipe(spec, "org.openrewrite.java.camel.migrate.ChangeTypes"),
java("""
@@ -825,127 +852,131 @@
}
@Test
- void testMultiIntrospectionSupport() {
+ void multiIntrospectionSupport() {
//language=java
rewriteRun(spec -> CamelQuarkusTestUtil.recipe(spec, "org.openrewrite.java.camel.migrate.ChangeTypes"),
- java("""
- import org.apache.camel.support.IntrospectionSupport;
+ java(
+ """
+ import org.apache.camel.support.IntrospectionSupport;
- import static org.apache.camel.support.IntrospectionSupport.getGetterShorthandName;
- import static org.apache.camel.support.IntrospectionSupport.isGetter;
- import static org.apache.camel.support.IntrospectionSupport.isSetter;
-
- public class Test {
+ import static org.apache.camel.support.IntrospectionSupport.getGetterShorthandName;
+ import static org.apache.camel.support.IntrospectionSupport.isGetter;
+ import static org.apache.camel.support.IntrospectionSupport.isSetter;
+
+ public class Test {
- public void test() {
- IntrospectionSupport is;
- isGetter(null);
- isSetter(null);
- getGetterShorthandName(null);
- }
- }
+ public void test() {
+ IntrospectionSupport is;
+ isGetter(null);
+ isSetter(null);
+ getGetterShorthandName(null);
+ }
+ }
""", """
- import org.apache.camel.impl.engine.IntrospectionSupport;
+ import org.apache.camel.impl.engine.IntrospectionSupport;
- import static org.apache.camel.impl.engine.IntrospectionSupport.*;
-
- public class Test {
+ import static org.apache.camel.impl.engine.IntrospectionSupport.*;
+
+ public class Test {
- public void test() {
- IntrospectionSupport is;
- isGetter(null);
- isSetter(null);
- getGetterShorthandName(null);
- }
- }
+ public void test() {
+ IntrospectionSupport is;
+ isGetter(null);
+ isSetter(null);
+ getGetterShorthandName(null);
+ }
+ }
"""));
}
@Test
void testarchetypeCatalogAsXml() {
//language=java
- rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java("""
- import org.apache.camel.catalog.CamelCatalog;
+ rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java(
+ """
+ import org.apache.camel.catalog.CamelCatalog;
- public class Test {
+ public class Test {
- static CamelCatalog catalog;
+ static CamelCatalog catalog;
- public void test() {
- String schema = catalog.archetypeCatalogAsXml();
- }
+ public void test() {
+ String schema = catalog.archetypeCatalogAsXml();
}
+ }
""",
"""
- import org.apache.camel.catalog.CamelCatalog;
+ import org.apache.camel.catalog.CamelCatalog;
- public class Test {
+ public class Test {
- static CamelCatalog catalog;
+ static CamelCatalog catalog;
- public void test() {
- String schema = /* Method 'archetypeCatalogAsXml' has been removed. */catalog.archetypeCatalogAsXml();
- }
+ public void test() {
+ String schema = /* Method 'archetypeCatalogAsXml' has been removed. */catalog.archetypeCatalogAsXml();
}
+ }
"""));
}
@Test
- void testMainListenerConfigureImpl() {
+ void mainListenerConfigureImpl() {
//language=java
- rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java("""
- import org.apache.camel.CamelContext;
- import org.apache.camel.main.MainListener;
+ rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java(
+ """
+ import org.apache.camel.CamelContext;
+ import org.apache.camel.main.MainListener;
- public class Test implements MainListener {
+ public class Test implements MainListener {
- @Override
- public void configure(CamelContext context) {
- //do something
- }
+ @Override
+ public void configure(CamelContext context) {
+ //do something
}
+ }
""",
"""
- import org.apache.camel.CamelContext;
- import org.apache.camel.main.MainListener;
+ import org.apache.camel.CamelContext;
+ import org.apache.camel.main.MainListener;
- public class Test implements MainListener {
+ public class Test implements MainListener {
- /* Method 'configure' was removed from `org.apache.camel.main.MainListener`, consider using 'beforeConfigure' or 'afterConfigure'. */@Override
- public void configure(CamelContext context) {
- //do something
- }
+ /* Method 'configure' was removed from `org.apache.camel.main.MainListener`, consider using 'beforeConfigure' or 'afterConfigure'. */@Override
+ public void configure(CamelContext context) {
+ //do something
}
+ }
"""));
}
@Test
- void testDumpRoutes() {
+ void dumpRoutes() {
//language=java
- rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java("""
- import org.apache.camel.CamelContext;
+ rewriteRun(spec -> spec.expectedCyclesThatMakeChanges(2), java(
+ """
+ import org.apache.camel.CamelContext;
- public class Test {
- public void test(CamelContext context) {
- boolean dump = context.isDumpRoutes();
- context.setDumpRoutes(true);
- }
+ public class Test {
+ public void test(CamelContext context) {
+ boolean dump = context.isDumpRoutes();
+ context.setDumpRoutes(true);
}
+ }
""",
"""
- import org.apache.camel.CamelContext;
+ import org.apache.camel.CamelContext;
- public class Test {
- public void test(CamelContext context) {
- boolean dump = /* Method 'getDumpRoutes' returns String value ('xml' or 'yaml' or 'false'). */context.getDumpRoutes();
- /* Method 'setDumpRoutes' accepts String parameter ('xml' or 'yaml' or 'false'). */context.setDumpRoutes(true);
- }
+ public class Test {
+ public void test(CamelContext context) {
+ boolean dump = /* Method 'getDumpRoutes' returns String value ('xml' or 'yaml' or 'false'). */context.getDumpRoutes();
+ /* Method 'setDumpRoutes' accepts String parameter ('xml' or 'yaml' or 'false'). */context.setDumpRoutes(true);
}
+ }
"""));
}
@Test
- void testAdapt3() {
+ void adapt3() {
//language=java
rewriteRun(java(
"""
@@ -982,44 +1013,45 @@
}
""",
"""
- import jakarta.enterprise.context.ApplicationScoped;
- import jakarta.inject.Inject;
- import jakarta.ws.rs.Consumes;
- import jakarta.ws.rs.GET;
- import jakarta.ws.rs.POST;
- import jakarta.ws.rs.Path;
- import jakarta.ws.rs.PathParam;
- import jakarta.ws.rs.core.MediaType;
+ import jakarta.enterprise.context.ApplicationScoped;
+ import jakarta.inject.Inject;
+ import jakarta.ws.rs.Consumes;
+ import jakarta.ws.rs.GET;
+ import jakarta.ws.rs.POST;
+ import jakarta.ws.rs.Path;
+ import jakarta.ws.rs.PathParam;
+ import jakarta.ws.rs.core.MediaType;
- import org.apache.camel.CamelContext;
- import org.apache.camel.ProducerTemplate;
- import org.apache.camel.builder.AdviceWith;
- import org.apache.camel.builder.AdviceWithRouteBuilder;
- import org.apache.camel.component.mock.MockEndpoint;
- import org.apache.camel.model.ModelCamelContext;
- import org.jboss.logging.Logger;
- import org.wildfly.common.Assert;
+ import org.apache.camel.CamelContext;
+ import org.apache.camel.ProducerTemplate;
+ import org.apache.camel.builder.AdviceWith;
+ import org.apache.camel.builder.AdviceWithRouteBuilder;
+ import org.apache.camel.component.mock.MockEndpoint;
+ import org.apache.camel.model.ModelCamelContext;
+ import org.jboss.logging.Logger;
+ import org.wildfly.common.Assert;
- public class Test {
- public void test(CamelContext context) {
- // advice the first route using the inlined AdviceWith route builder
- // which has extended capabilities than the regular route builder
- AdviceWith.adviceWith(((ModelCamelContext)context).getRouteDefinition("forMocking"), context,
- new AdviceWithRouteBuilder() {
- @Override
- public void configure() throws Exception {
- mockEndpoints("direct:mock.*", "log:mock.*");
- }
- });
+ public class Test {
+ public void test(CamelContext context) {
+ // advice the first route using the inlined AdviceWith route builder
+ // which has extended capabilities than the regular route builder
+ AdviceWith.adviceWith(((ModelCamelContext)context).getRouteDefinition("forMocking"), context,
+ new AdviceWithRouteBuilder() {
+ @Override
+ public void configure() throws Exception {
+ mockEndpoints("direct:mock.*", "log:mock.*");
}
- }
+ });
+ }
+ }
"""));
}
@Test
- void testBacklogTracerEventMessage() {
+ void backlogTracerEventMessage() {
//language=java
- rewriteRun(java("""
+ rewriteRun(java(
+ """
import org.apache.camel.api.management.mbean.BacklogTracerEventMessage;
public class Test {
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelEIPRecipeTest.java b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelEIPRecipeTest.java
index c781bd9..f674492 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelEIPRecipeTest.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelEIPRecipeTest.java
@@ -3,12 +3,14 @@ io.moderne.worker.execution.RecipeMapper
import static org.openrewrite.java.Assertions.java;
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-public class CamelEIPRecipeTest implements RewriteTest {
+class CamelEIPRecipeTest implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -17,88 +19,92 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testRemovedEIPInOptionalOut() {
+ void removedEIPInOptionalOut() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.builder.RouteBuilder;
+ rewriteRun(java(
+ """
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .inOut("activemq:queue:testqueue")
- .to("log:result_a");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .inOut("activemq:queue:testqueue")
+ .to("log:result_a");
}
+ }
""", """
- import org.apache.camel.ExchangePattern;
- import org.apache.camel.builder.RouteBuilder;
+ import org.apache.camel.ExchangePattern;
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .setExchangePattern(ExchangePattern.InOut).to("activemq:queue:testqueue")
- .to("log:result_a");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .setExchangePattern(ExchangePattern.InOut).to("activemq:queue:testqueue")
+ .to("log:result_a");
}
+ }
"""
));
}
@Test
- void testRemovedEIPOutOptionalIn() {
+ void removedEIPOutOptionalIn() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.builder.RouteBuilder;
+ rewriteRun(java(
+ """
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .inOut("activemq:queue:testqueue")
- .to("log:result_a");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .inOut("activemq:queue:testqueue")
+ .to("log:result_a");
}
+ }
""", """
- import org.apache.camel.ExchangePattern;
- import org.apache.camel.builder.RouteBuilder;
+ import org.apache.camel.ExchangePattern;
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .setExchangePattern(ExchangePattern.InOut).to("activemq:queue:testqueue")
- .to("log:result_a");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .setExchangePattern(ExchangePattern.InOut).to("activemq:queue:testqueue")
+ .to("log:result_a");
}
+ }
"""
));
}
@Test
- void testRemovedEIPOutIn() {
+ void removedEIPOutIn() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.ExchangePattern;
- import org.apache.camel.builder.RouteBuilder;
+ rewriteRun(java(
+ """
+ import org.apache.camel.ExchangePattern;
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .setExchangePattern(ExchangePattern.InOut).to("activemq:queue:testqueue")
- .to("log:result_a");
- }
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .setExchangePattern(ExchangePattern.InOut).to("activemq:queue:testqueue")
+ .to("log:result_a");
+ }
+ }
"""
));
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelPomRecipeTest.java b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelPomRecipeTest.java
index d270e2e..474e50b 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelPomRecipeTest.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelPomRecipeTest.java
@@ -3,12 +3,14 @@ io.moderne.worker.execution.RecipeMapper
import static org.openrewrite.maven.Assertions.pomXml;
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-public class CamelPomRecipeTest implements RewriteTest {
+class CamelPomRecipeTest implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -17,8 +19,9 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testRemovedExtensions() {
+ void removedExtensions() {
//language=xml
rewriteRun(pomXml(
"""
@@ -186,7 +189,7 @@
}
@Test
- void testRemovedComponentsReal() {
+ void removedComponentsReal() {
//language=xml
rewriteRun(pomXml(
"""
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CameXmlDslRecipeTest.java b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CameXmlDslRecipeTest.java
index 525b6a3..d537daf 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CameXmlDslRecipeTest.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CameXmlDslRecipeTest.java
@@ -3,12 +3,14 @@ io.moderne.worker.execution.RecipeMapper
import static org.openrewrite.xml.Assertions.xml;
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-public class CameXmlDslRecipeTest implements RewriteTest {
+class CameXmlDslRecipeTest implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -17,8 +19,9 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testDescription() {
+ void description() {
//language=xml
rewriteRun(xml("""
<routes xmlns="http://camel.apache.org/schema/spring">
@@ -40,27 +43,27 @@
</route>
</routes>
""", """
- <routes xmlns="http://camel.apache.org/schema/spring">
- <route id="myRoute" description="Something that this route do">
- <from uri="kafka:cheese"/>
- <setBody>
- <constant>Hello Camel K!</constant>
- </setBody>
- <to uri="log:info"/>
- </route>
- <route id="myRoute2" description="Something that this route2 do">
- <from uri="kafka:cheese"/>
- <setBody>
- <constant>Hello Camel K!</constant>
- </setBody>
- <to uri="log:info"/>
- </route>
- </routes>
+ <routes xmlns="http://camel.apache.org/schema/spring">
+ <route id="myRoute" description="Something that this route do">
+ <from uri="kafka:cheese"/>
+ <setBody>
+ <constant>Hello Camel K!</constant>
+ </setBody>
+ <to uri="log:info"/>
+ </route>
+ <route id="myRoute2" description="Something that this route2 do">
+ <from uri="kafka:cheese"/>
+ <setBody>
+ <constant>Hello Camel K!</constant>
+ </setBody>
+ <to uri="log:info"/>
+ </route>
+ </routes>
"""));
}
@Test
- void testCircuitBreakerFull() {
+ void circuitBreakerFull() {
//language=xml
rewriteRun(xml("""
<differentContext>
@@ -87,7 +90,7 @@
}
@Test
- void testCircuitBreaker() {
+ void circuitBreaker() {
//language=xml
rewriteRun(xml("""
<route>
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelHttpTest.java b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelHttpTest.java
index 5c299fd..c78e3ef 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelHttpTest.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelHttpTest.java
@@ -1,14 +1,16 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.camel30;
+import static org.openrewrite.java.Assertions.java;
+
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-import static org.openrewrite.java.Assertions.java;
-
-public class CamelHttpTest implements RewriteTest {
+class CamelHttpTest implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -19,121 +21,122 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testHttp() {
+ void http() {
//language=java
rewriteRun(java(
"""
- import jakarta.inject.Named;
+ import jakarta.inject.Named;
- import org.apache.http.HttpHost;
- import org.apache.http.auth.AuthScope;
- import org.apache.http.auth.UsernamePasswordCredentials;
- import org.apache.http.client.protocol.HttpClientContext;
- import org.apache.http.impl.auth.BasicScheme;
- import org.apache.http.impl.client.BasicAuthCache;
- import org.apache.http.impl.client.BasicCredentialsProvider;
- import org.apache.http.protocol.HttpContext;
- import org.eclipse.microprofile.config.ConfigProvider;
+ import org.apache.http.HttpHost;
+ import org.apache.http.auth.AuthScope;
+ import org.apache.http.auth.UsernamePasswordCredentials;
+ import org.apache.http.client.protocol.HttpClientContext;
+ import org.apache.http.impl.auth.BasicScheme;
+ import org.apache.http.impl.client.BasicAuthCache;
+ import org.apache.http.impl.client.BasicCredentialsProvider;
+ import org.apache.http.protocol.HttpContext;
+ import org.eclipse.microprofile.config.ConfigProvider;
- import static org.apache.camel.quarkus.component.http.it.HttpResource.USER_ADMIN;
- import static org.apache.camel.quarkus.component.http.it.HttpResource.USER_ADMIN_PASSWORD;
+ import static org.apache.camel.quarkus.component.http.it.HttpResource.USER_ADMIN;
+ import static org.apache.camel.quarkus.component.http.it.HttpResource.USER_ADMIN_PASSWORD;
- public class HttpProducers {
+ public class HttpProducers {
- @Named
- HttpContext basicAuthContext() {
- Integer port = ConfigProvider.getConfig().getValue("quarkus.http.test-port", Integer.class);
+ @Named
+ HttpContext basicAuthContext() {
+ Integer port = ConfigProvider.getConfig().getValue("quarkus.http.test-port", Integer.class);
- UsernamePasswordCredentials credentials = new UsernamePasswordCredentials(USER_ADMIN, USER_ADMIN_PASSWORD);
- BasicCredentialsProvider provider = new BasicCredentialsProvider();
- provider.setCredentials(AuthScope.ANY, credentials);
+ UsernamePasswordCredentials credentials = new UsernamePasswordCredentials(USER_ADMIN, USER_ADMIN_PASSWORD);
+ BasicCredentialsProvider provider = new BasicCredentialsProvider();
+ provider.setCredentials(AuthScope.ANY, credentials);
- BasicAuthCache authCache = new BasicAuthCache();
- BasicScheme basicAuth = new BasicScheme();
- authCache.put(new HttpHost("localhost", port), basicAuth);
+ BasicAuthCache authCache = new BasicAuthCache();
+ BasicScheme basicAuth = new BasicScheme();
+ authCache.put(new HttpHost("localhost", port), basicAuth);
- HttpClientContext context = HttpClientContext.create();
- context.setAuthCache(authCache);
- context.setCredentialsProvider(provider);
+ HttpClientContext context = HttpClientContext.create();
+ context.setAuthCache(authCache);
+ context.setCredentialsProvider(provider);
- return context;
- }
+ return context;
}
+ }
""",
"""
- import jakarta.inject.Named;
- import org.apache.hc.client5.http.auth.AuthScope;
- import org.apache.hc.client5.http.auth.UsernamePasswordCredentials;
- import org.apache.hc.client5.http.impl.auth.BasicAuthCache;
- import org.apache.hc.client5.http.impl.auth.BasicCredentialsProvider;
- import org.apache.hc.client5.http.impl.auth.BasicScheme;
- import org.apache.hc.client5.http.protocol.HttpClientContext;
- import org.apache.hc.core5.http.HttpHost;
- import org.apache.hc.core5.http.protocol.HttpContext;
- import org.eclipse.microprofile.config.ConfigProvider;
+ import jakarta.inject.Named;
+ import org.apache.hc.client5.http.auth.AuthScope;
+ import org.apache.hc.client5.http.auth.UsernamePasswordCredentials;
+ import org.apache.hc.client5.http.impl.auth.BasicAuthCache;
+ import org.apache.hc.client5.http.impl.auth.BasicCredentialsProvider;
+ import org.apache.hc.client5.http.impl.auth.BasicScheme;
+ import org.apache.hc.client5.http.protocol.HttpClientContext;
+ import org.apache.hc.core5.http.HttpHost;
+ import org.apache.hc.core5.http.protocol.HttpContext;
+ import org.eclipse.microprofile.config.ConfigProvider;
- import static org.apache.camel.quarkus.component.http.it.HttpResource.USER_ADMIN;
- import static org.apache.camel.quarkus.component.http.it.HttpResource.USER_ADMIN_PASSWORD;
+ import static org.apache.camel.quarkus.component.http.it.HttpResource.USER_ADMIN;
+ import static org.apache.camel.quarkus.component.http.it.HttpResource.USER_ADMIN_PASSWORD;
- public class HttpProducers {
+ public class HttpProducers {
- @Named
- HttpContext basicAuthContext() {
- Integer port = ConfigProvider.getConfig().getValue("quarkus.http.test-port", Integer.class);
+ @Named
+ HttpContext basicAuthContext() {
+ Integer port = ConfigProvider.getConfig().getValue("quarkus.http.test-port", Integer.class);
- UsernamePasswordCredentials credentials = new UsernamePasswordCredentials(USER_ADMIN, USER_ADMIN_PASSWORD);
- BasicCredentialsProvider provider = new BasicCredentialsProvider();
- provider.setCredentials(new AuthScope(null, -1), credentials);
+ UsernamePasswordCredentials credentials = new UsernamePasswordCredentials(USER_ADMIN, USER_ADMIN_PASSWORD);
+ BasicCredentialsProvider provider = new BasicCredentialsProvider();
+ provider.setCredentials(new AuthScope(null, -1), credentials);
- BasicAuthCache authCache = new BasicAuthCache();
- BasicScheme basicAuth = new BasicScheme();
- authCache.put(new HttpHost("localhost", port), basicAuth);
+ BasicAuthCache authCache = new BasicAuthCache();
+ BasicScheme basicAuth = new BasicScheme();
+ authCache.put(new HttpHost("localhost", port), basicAuth);
- HttpClientContext context = HttpClientContext.create();
- context.setAuthCache(authCache);
- context.setCredentialsProvider(provider);
+ HttpClientContext context = HttpClientContext.create();
+ context.setAuthCache(authCache);
+ context.setCredentialsProvider(provider);
- return context;
- }
+ return context;
}
+ }
"""));
}
@Test
- void testNoopHostnameVerifier() {
+ void noopHostnameVerifier() {
//language=java
rewriteRun(java(
"""
- import jakarta.inject.Named;
- import org.apache.camel.CamelContext;
- import org.apache.http.conn.ssl.NoopHostnameVerifier;
- import org.eclipse.microprofile.config.ConfigProvider;
-
- public class HttpProducers {
-
- CamelContext context;
+ import jakarta.inject.Named;
+ import org.apache.camel.CamelContext;
+ import org.apache.http.conn.ssl.NoopHostnameVerifier;
+ import org.eclipse.microprofile.config.ConfigProvider;
+
+ public class HttpProducers {
+
+ CamelContext context;
- @Named
- public NoopHostnameVerifier x509HostnameVerifier() {
- return NoopHostnameVerifier.INSTANCE;
- }
- }
+ @Named
+ public NoopHostnameVerifier x509HostnameVerifier() {
+ return NoopHostnameVerifier.INSTANCE;
+ }
+ }
""",
"""
- import jakarta.inject.Named;
- import org.apache.camel.CamelContext;
- import org.apache.hc.client5.http.conn.ssl.NoopHostnameVerifier;
- import org.eclipse.microprofile.config.ConfigProvider;
+ import jakarta.inject.Named;
+ import org.apache.camel.CamelContext;
+ import org.apache.hc.client5.http.conn.ssl.NoopHostnameVerifier;
+ import org.eclipse.microprofile.config.ConfigProvider;
+
+ public class HttpProducers {
- public class HttpProducers {
-
- CamelContext context;
-
- @Named
- public NoopHostnameVerifier x509HostnameVerifier() {
- return NoopHostnameVerifier.INSTANCE;
- }
- }
+ CamelContext context;
+
+ @Named
+ public NoopHostnameVerifier x509HostnameVerifier() {
+ return NoopHostnameVerifier.INSTANCE;
+ }
+ }
"""));
}
}
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelBeanRecipeTest.java b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelBeanRecipeTest.java
index 870e813..b82f16b 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelBeanRecipeTest.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelBeanRecipeTest.java
@@ -3,12 +3,14 @@ io.moderne.worker.execution.RecipeMapper
import static org.openrewrite.java.Assertions.java;
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-public class CamelBeanRecipeTest implements RewriteTest {
+class CamelBeanRecipeTest implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -17,130 +19,136 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testClassTypeAndInt() {
+ void classTypeAndInt() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.builder.RouteBuilder;
+ rewriteRun(java(
+ """
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .to("bean:myBean?method=foo(com.foo.MyOrder, int)");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .to("bean:myBean?method=foo(com.foo.MyOrder, int)");
}
+ }
""", """
- import org.apache.camel.builder.RouteBuilder;
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .to("bean:myBean?method=foo(com.foo.MyOrder.class, int.class)");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .to("bean:myBean?method=foo(com.foo.MyOrder.class, int.class)");
}
+ }
"""
));
}
@Test
- void testClassTypeAndBoolean() {
+ void classTypeAndBoolean() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.builder.RouteBuilder;
+ rewriteRun(java(
+ """
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .to("bean:myBean?method=foo(com.foo.MyOrder, true)");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .to("bean:myBean?method=foo(com.foo.MyOrder, true)");
}
+ }
""", """
- import org.apache.camel.builder.RouteBuilder;
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .to("bean:myBean?method=foo(com.foo.MyOrder.class, true)");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .to("bean:myBean?method=foo(com.foo.MyOrder.class, true)");
}
+ }
"""
));
}
@Test
- void testClassTypeAndFloat() {
+ void classTypeAndFloat() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.builder.RouteBuilder;
+ rewriteRun(java(
+ """
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .to("bean:myBean?method=foo(com.foo.MyOrder, float)");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .to("bean:myBean?method=foo(com.foo.MyOrder, float)");
}
+ }
""", """
- import org.apache.camel.builder.RouteBuilder;
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .to("bean:myBean?method=foo(com.foo.MyOrder.class, float.class)");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .to("bean:myBean?method=foo(com.foo.MyOrder.class, float.class)");
}
+ }
"""
));
}
@Test
- void testDoubleAndChar() {
+ void doubleAndChar() {
//language=java
- rewriteRun(java("""
- import org.apache.camel.builder.RouteBuilder;
+ rewriteRun(java(
+ """
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .to("bean:myBean?method=foo(double, char)");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .to("bean:myBean?method=foo(double, char)");
}
+ }
""", """
- import org.apache.camel.builder.RouteBuilder;
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .to("bean:myBean?method=foo(double.class, char.class)");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .to("bean:myBean?method=foo(double.class, char.class)");
}
+ }
"""
));
}
@Test
- void testMultipleTo() {
+ void multipleTo() {
//language=java
- rewriteRun(java("""
+ rewriteRun(java(
+ """
import org.apache.camel.builder.RouteBuilder;
public class MySimpleToDRoute extends RouteBuilder {
@@ -153,17 +161,17 @@
}
}
""", """
- import org.apache.camel.builder.RouteBuilder;
+ import org.apache.camel.builder.RouteBuilder;
- public class MySimpleToDRoute extends RouteBuilder {
+ public class MySimpleToDRoute extends RouteBuilder {
- @Override
- public void configure() {
- from("direct:a")
- .to("bean:myBean?method=foo(double.class, char.class)")
- .to("bean:myBean?method=bar(float.class, int.class)");
- }
+ @Override
+ public void configure() {
+ from("direct:a")
+ .to("bean:myBean?method=foo(double.class, char.class)")
+ .to("bean:myBean?method=bar(float.class, int.class)");
}
+ }
"""
));
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelYamlTest.java b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelYamlTest.java
index dc7dcdf..2f5971d 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelYamlTest.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelYamlTest.java
@@ -1,12 +1,14 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.camel30;
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
import org.openrewrite.yaml.Assertions;
-public class CamelYamlTest implements RewriteTest {
+class CamelYamlTest implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -14,8 +16,9 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testStepsToFrom1() {
+ void stepsToFrom1() {
//language=yaml
rewriteRun(Assertions.yaml("""
route:
@@ -33,7 +36,7 @@
}
@Test
- void testStepsToFrom2() {
+ void stepsToFrom2() {
//language=yaml
rewriteRun(Assertions.yaml("""
from:
@@ -49,7 +52,7 @@
}
@Test
- void testStepsToFrom3() {
+ void stepsToFrom3() {
//language=yaml
rewriteRun(Assertions.yaml("""
- from:
@@ -79,7 +82,7 @@
}
@Test
- void testRouteConfigurationWithOnException() {
+ void routeConfigurationWithOnException() {
//language=yaml
rewriteRun(Assertions.yaml("""
- route-configuration:
@@ -110,7 +113,7 @@
}
@Test
- void testRouteConfigurationWithoutOnException() {
+ void routeConfigurationWithoutOnException() {
//language=yaml
rewriteRun(Assertions.yaml("""
- route-configuration:
@@ -122,7 +125,7 @@
}
@Test
- void testDoubleDocument() {
+ void doubleDocument() {
//language=yaml
rewriteRun(Assertions.yaml("""
- route-configuration:
@@ -178,7 +181,7 @@
}
@Test
- void testDoubleDocumentSimple() {
+ void doubleDocumentSimple() {
//language=yaml
rewriteRun(Assertions.yaml("""
- route-configuration:
@@ -196,7 +199,7 @@
}
@Test
- void testRouteConfigurationIdempotent() {
+ void routeConfigurationIdempotent() {
//language=yaml
rewriteRun(Assertions.yaml("""
- route-configuration:
diff --git a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelAPIsPropertiesTest.java b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelAPIsPropertiesTest.java
index 2e118ab..69796d0 100644
--- a/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelAPIsPropertiesTest.java
+++ b/recipes-tests/src/test/java/io/quarkus/updates/camel30/CamelAPIsPropertiesTest.java
@@ -1,13 +1,15 @@ io.moderne.worker.execution.RecipeMapper
package io.quarkus.updates.camel30;
import org.junit.jupiter.api.Test;
+
+import org.openrewrite.DocumentExample;
import org.openrewrite.java.JavaParser;
import org.openrewrite.properties.Assertions;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.test.TypeValidation;
-public class CamelAPIsPropertiesTest implements RewriteTest {
+class CamelAPIsPropertiesTest implements RewriteTest {
@Override
public void defaults(RecipeSpec spec) {
@@ -16,27 +18,30 @@
.typeValidationOptions(TypeValidation.none());
}
+ @DocumentExample
@Test
- void testRejectedPolicyDiscardOldeste() {
- rewriteRun(Assertions.properties("""
- #test
- camel.threadpool.rejectedPolicy=DiscardOldest
+ void rejectedPolicyDiscardOldeste() {
+ rewriteRun(Assertions.properties(
+ """
+ #test
+ camel.threadpool.rejectedPolicy=DiscardOldest
""",
"""
- #test
- camel.threadpool.rejectedPolicy=Abort #DiscardOldest has been removed, consider Abort
+ #test
+ camel.threadpool.rejectedPolicy=Abort #DiscardOldest has been removed, consider Abort
"""));
}
@Test
- void testRejectedPolicyDiscard() {
- rewriteRun(Assertions.properties("""
- #test
- camel.threadpool.rejectedPolicy=Discard
+ void rejectedPolicyDiscard() {
+ rewriteRun(Assertions.properties(
+ """
+ #test
+ camel.threadpool.rejectedPolicy=Discard
""",
"""
- #test
- camel.threadpool.rejectedPolicy=Abort #Discard has been removed, consider Abort
+ #test
+ camel.threadpool.rejectedPolicy=Abort #Discard has been removed, consider Abort
"""));
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.