Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix images of heroes and villains #193

Merged
merged 1 commit into from
Nov 12, 2022
Merged

fix images of heroes and villains #193

merged 1 commit into from
Nov 12, 2022

Conversation

oliv37
Copy link
Contributor

@oliv37 oliv37 commented Nov 7, 2022 •
edited
Loading

some images have a wrong url, giving a poor rendering when launching ui-super-heroes app (as you can see below)

image

I fixed some of them and delete the ones that couldn't be found on www.superherodb.com

@cescoffier cescoffier merged commit bc7d659 into quarkusio:main Nov 12, 2022
@cescoffier
Copy link
Member

Thanks!

@fedinskiy
Copy link
Contributor

This change deleted several superheroes and leaded to failing HeroResourceIT:

  1. git checkout bc7d6594a5aeb9c6f9b6d63241ae090ed5e4cffe #after this merge
  2. mvn clean verify -Dit.test=HeroResourceIT # failure
  3. git checkout 8ddd2f4f # parent commit
  4. `mvn clean verify -Dit.test=HeroResourceIT # success

This was later fixed there: #200
I suggest to add more CI checks to avoid such issues in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliv37 @cescoffier @fedinskiy