-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Assembly and adding a 3rd ZIP file with only the core #400
Conversation
🚀 PR Preview 0b9f947 has been successfully built and deployed to https://quarkiverse-quarkus-workshops-pr-400-preview.surge.sh |
I think we should look into the file sizes a bit, and perhaps diff the before and after contents, and add a few
The workshop starter file shrank by 61%, but that's only 220kb. And I suspect the 'missing' content is the content we spotted in the workshop as 'shouldn't be there'. So probably all good, but maybe worth double-checking. For the complete zip, it's gone up by 29mb, or 2400%. That seems like something's snuck in that shouldn't be there. Although, oddly, that's the file that changed the least. |
@holly-cummins yes, the workshop starter file shrank because I removed the |
I only include files instead of excluding files
Fix #388