Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Assembly and adding a 3rd ZIP file with only the core #400

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

agoncal
Copy link
Collaborator

@agoncal agoncal commented Oct 11, 2023

I only include files instead of excluding files

Fix #388

@agoncal agoncal requested a review from holly-cummins October 11, 2023 14:41
@agoncal agoncal self-assigned this Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

🚀 PR Preview 0b9f947 has been successfully built and deployed to https://quarkiverse-quarkus-workshops-pr-400-preview.surge.sh

@holly-cummins
Copy link
Collaborator

I think we should look into the file sizes a bit, and perhaps diff the before and after contents, and add a few <excludes> alongside the includes for the complete zip.

BIN +29.2 MB (2400%)
[quarkus-workshop-super-heroes/dist/quarkus-super-heroes-workshop-complete.zip](https://github.com/quarkusio/quarkus-workshops/pull/400/files#diff-dc822259003afc5364b4789e08bc9ef71ee5684b5afb0b4b60923f6d69df7134)
Viewed
Binary file not shown.
Binary file added BIN +1.01 MB
[quarkus-workshop-super-heroes/dist/quarkus-super-heroes-workshop-core.zip](https://github.com/quarkusio/quarkus-workshops/pull/400/files#diff-57749a52640f73712a155ae951f1bb6101834932240dec8d4d868a738da6cea6)
Viewed
Binary file not shown.
Binary file modified BIN -220 KB (61%)
[quarkus-workshop-super-heroes/dist/quarkus-super-heroes-workshop.zip](https://github.com/quarkusio/quarkus-workshops/pull/400/files#diff-96a6b76a4cf06f3ada3439e650bda96648ccb025f2c2907ad776036289db4080)

The workshop starter file shrank by 61%, but that's only 220kb. And I suspect the 'missing' content is the content we spotted in the workshop as 'shouldn't be there'. So probably all good, but maybe worth double-checking.

For the complete zip, it's gone up by 29mb, or 2400%. That seems like something's snuck in that shouldn't be there. Although, oddly, that's the file that changed the least.

@agoncal
Copy link
Collaborator Author

agoncal commented Oct 12, 2023

@holly-cummins yes, the workshop starter file shrank because I removed the load-super-heroes. One day we will turn it into a Quarkus CLI so we can add a new chapter "how to create a CLI with Quarkus"

@agoncal agoncal merged commit 0b9f947 into quarkusio:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The assembly should include the needed code instead of excluding what's not needed
2 participants