Merge pull request #4223 from stuartwdouglas/register-ref

Allow additional classes to be easily registered for reflection
quarkusio · Sep 27, 2019 · 35e1bb6 · 35e1bb6
2 parents e1f7a18 + 03b84b0
commit 35e1bb6
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 2 deletions.
diff --git a/.../deployment/src/main/java/io/quarkus/deployment/steps/RegisterForReflectionBuildStep.java b/.../deployment/src/main/java/io/quarkus/deployment/steps/RegisterForReflectionBuildStep.java
@@ -3,8 +3,10 @@
 import javax.inject.Inject;
 
 import org.jboss.jandex.AnnotationInstance;
+import org.jboss.jandex.AnnotationValue;
 import org.jboss.jandex.ClassInfo;
 import org.jboss.jandex.DotName;
+import org.jboss.jandex.Type;
 
 import io.quarkus.deployment.annotations.BuildProducer;
 import io.quarkus.deployment.annotations.BuildStep;
@@ -31,7 +33,15 @@ public void build() throws Exception {
             ClassInfo target = i.target().asClass();
             boolean methods = i.value("methods") == null || i.value("methods").asBoolean();
             boolean fields = i.value("fields") == null || i.value("fields").asBoolean();
-            reflectiveClass.produce(new ReflectiveClassBuildItem(methods, fields, target.name().toString()));
+            AnnotationValue targetsValue = i.value("targets");
+            if (targetsValue == null) {
+                reflectiveClass.produce(new ReflectiveClassBuildItem(methods, fields, target.name().toString()));
+            } else {
+                Type[] targets = targetsValue.asClassArray();
+                for (Type type : targets) {
+                    reflectiveClass.produce(new ReflectiveClassBuildItem(methods, fields, type.name().toString()));
+                }
+            }
         }
     }
 

diff --git a/core/runtime/src/main/java/io/quarkus/runtime/annotations/RegisterForReflection.java b/core/runtime/src/main/java/io/quarkus/runtime/annotations/RegisterForReflection.java
@@ -21,4 +21,13 @@
      * If the fields should be registered
      */
     boolean fields() default true;
+
+    /**
+     * Alternative classes that should actually be registered for reflection instead of the current class.
+     *
+     * This allows for classes in 3rd party libraries to be registered without modification or writing an
+     * extension. If this is set then the class it is placed on is not registered for reflection, so this should
+     * generally just be placed on an empty class that is not otherwise used.
+     */
+    Class<?>[] targets() default {};
 }
diff --git a/integration-tests/main/src/main/java/io/quarkus/it/rest/TestResource.java b/integration-tests/main/src/main/java/io/quarkus/it/rest/TestResource.java
@@ -388,7 +388,6 @@ public interface MyInterface {
         String getName();
     }
 
-    @RegisterForReflection
     public static class MyEntity {
         private String name;
         private String value;
@@ -410,6 +409,11 @@ public void setValue(String value) {
         }
     }
 
+    @RegisterForReflection(targets = MyEntity.class)
+    public static class EmptyClass {
+
+    }
+
     public static class MyOpenApiEntityV1 {
         private String name;