Apply suggestions from code review

Co-authored-by: Yoann Rodière <[email protected]>
quarkusio · May 11, 2023 · 487ae38 · 487ae38
1 parent a42560b
commit 487ae38
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/docs/src/main/asciidoc/transaction.adoc b/docs/src/main/asciidoc/transaction.adoc
@@ -370,7 +370,7 @@ To enable this capability, you need to set `quarkus.transaction-manager.object-s
 
 If you enable `quarkus.transaction-manager.object-store.create-table`, the transaction log table will be created automatically if it does not exist.
 
-NOTE: When enabling this capability, it needs to require assignment of a transaction node identifier.
+NOTE: When enabling this capability, the transaction node identifier must be set through `quarkus.transaction-manager.node-name`.
 
 
 == Why always having a transaction manager?

diff --git a/...narayana-jta/runtime/src/main/java/io/quarkus/narayana/jta/runtime/QuarkusDataSource.java b/...narayana-jta/runtime/src/main/java/io/quarkus/narayana/jta/runtime/QuarkusDataSource.java
@@ -15,7 +15,7 @@
 
 public class QuarkusDataSource implements DataSource {
     private final Optional<String> dsName;
-    private DataSource datasource;
+    private volatile DataSource datasource;
 
     public QuarkusDataSource(Optional<String> dsName) {
         this.dsName = dsName;

diff --git a/...untime/src/main/java/io/quarkus/narayana/jta/runtime/TransactionManagerConfiguration.java b/...untime/src/main/java/io/quarkus/narayana/jta/runtime/TransactionManagerConfiguration.java
@@ -63,7 +63,7 @@ public final class TransactionManagerConfiguration {
 @ConfigGroup
 class ObjectStoreConfig {
     /**
-     * The directory name of location of the transaction logs.
+     * The name of the directory where the transaction logs will be stored when using the {@code file-system} object store.
      * If the value is not absolute then the directory is relative
      * to the <em>user.dir</em> system property.
      */
@@ -77,7 +77,7 @@ class ObjectStoreConfig {
     public ObjectStoreType type;
 
     /**
-     * The datasource name used in JDBCStore.
+     * The name of the datasource where the transaction logs will be stored when using the {@code jdbc} object store.
      * <p>
      * If undefined, it will use the default datasource.
      */
@@ -91,7 +91,7 @@ class ObjectStoreConfig {
     public boolean createTable;
 
     /**
-     * Whether to drop the table.
+     * Whether to drop the table on startup.
      */
     @ConfigItem(defaultValue = "false")
     public boolean dropTable;