Skip to content

Commit

Permalink
Remove useless Class.forName
Browse files Browse the repository at this point in the history
  • Loading branch information
geoand committed Sep 4, 2019
1 parent 78b05c9 commit 48fec53
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -128,18 +128,14 @@ void generateJsonbContextResolver(ClassOutput classOutput, Map<String, String> t
// build up the serializers array that will be passed to JsonbConfig
createJsonb.writeArrayValue(serializersArray, createJsonb.load(i), serializer);

ResultHandle clazz = createJsonb.invokeStaticMethod(
MethodDescriptor.ofMethod(Class.class, "forName", Class.class, String.class),
createJsonb.load(entry.getKey()));

// add a ContainerSerializerProvider for the serializer
ResultHandle serializerProvider = createJsonb.newInstance(
MethodDescriptor.ofConstructor(SimpleContainerSerializerProvider.class, JsonbSerializer.class),
serializer);
createJsonb.invokeVirtualMethod(
MethodDescriptor.ofMethod(MappingContext.class, "addSerializerProvider", void.class,
Class.class, ContainerSerializerProvider.class),
mappingContext, clazz, serializerProvider);
mappingContext, createJsonb.loadClass(entry.getKey()), serializerProvider);

i++;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,10 @@ void generateJsonbContextResolver(ClassOutput classOutput) {
ResultHandle arcContainer = instanceNull
.invokeStaticMethod(MethodDescriptor.ofMethod(Arc.class, "container", ArcContainer.class));

ResultHandle jsonbClass = instanceNull.invokeStaticMethod(
MethodDescriptor.ofMethod(Class.class, "forName", Class.class, String.class),
instanceNull.load(Jsonb.class.getName()));
ResultHandle instanceHandle = instanceNull.invokeInterfaceMethod(
MethodDescriptor.ofMethod(ArcContainer.class, "instance", InstanceHandle.class, Class.class,
Annotation[].class),
arcContainer, jsonbClass, instanceNull.loadNull());
arcContainer, instanceNull.loadClass(Jsonb.class), instanceNull.loadNull());
ResultHandle get = instanceNull.invokeInterfaceMethod(
MethodDescriptor.ofMethod(InstanceHandle.class, "get", Object.class),
instanceHandle);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,11 @@ protected void generateNotNull(GenerateContext context) {
ResultHandle serializationContext = context.getSerializationContext();

ResultHandle marshaller = bytecodeCreator.checkCast(serializationContext, Marshaller.class);
ResultHandle enclosingTypeClass = bytecodeCreator.invokeStaticMethod(
MethodDescriptor.ofMethod(Class.class, "forName", Class.class, String.class),
bytecodeCreator.load(enclosingType.name().toString()));

ResultHandle propertyCachedSerializer = bytecodeCreator.invokeStaticMethod(
MethodDescriptor.ofMethod(UnhandledTypeGeneratorUtil.class, "getSerializerForUnhandledType",
JsonbSerializer.class, Marshaller.class, Class.class, Object.class, String.class),
marshaller, enclosingTypeClass,
marshaller, bytecodeCreator.loadClass(enclosingType.name().toString()),
context.getCurrentItem(), bytecodeCreator.load(propertyName));

bytecodeCreator.invokeInterfaceMethod(
Expand Down

0 comments on commit 48fec53

Please sign in to comment.