Don't log connection closed exceptions as ERROR in websockets-next

The clients can choose to close at any time, so it does not make sense to fill up logs with closed connection messages
quarkusio · Apr 24, 2024 · 62cd218 · 62cd218
1 parent 20ed823
commit 62cd218
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 10 deletions.
diff --git a/...ver/runtime/src/main/java/io/quarkus/websockets/next/runtime/WebSocketServerRecorder.java b/...ver/runtime/src/main/java/io/quarkus/websockets/next/runtime/WebSocketServerRecorder.java
@@ -116,8 +116,8 @@ public void handle(Void event) {
                                                         LOG.debugf("@OnTextMessage callback consuming Multi completed: %s",
                                                                 connection);
                                                     } else {
-                                                        LOG.errorf(r.cause(),
-                                                                "Unable to complete @OnTextMessage callback consuming Multi: %s",
+                                                        logFailure(r.cause(),
+                                                                "Unable to complete @OnTextMessage callback consuming Multi",
                                                                 connection);
                                                     }
                                                 });
@@ -134,16 +134,16 @@ public void handle(Void event) {
                                                         LOG.debugf("@OnBinaryMessage callback consuming Multi completed: %s",
                                                                 connection);
                                                     } else {
-                                                        LOG.errorf(r.cause(),
-                                                                "Unable to complete @OnBinaryMessage callback consuming Multi: %s",
+                                                        logFailure(r.cause(),
+                                                                "Unable to complete @OnBinaryMessage callback consuming Multi",
                                                                 connection);
                                                     }
                                                 });
                                             }
                                         });
                                     }
                                 } else {
-                                    LOG.errorf(r.cause(), "Unable to complete @OnOpen callback: %s", connection);
+                                    logFailure(r.cause(), "Unable to complete @OnOpen callback", connection);
                                 }
                             });
                         }
@@ -156,7 +156,7 @@ public void handle(Void event) {
                                 if (r.succeeded()) {
                                     LOG.debugf("@OnTextMessage callback consumed text message: %s", connection);
                                 } else {
-                                    LOG.errorf(r.cause(), "Unable to consume text message in @OnTextMessage callback: %s",
+                                    logFailure(r.cause(), "Unable to consume text message in @OnTextMessage callback",
                                             connection);
                                 }
                             });
@@ -184,7 +184,7 @@ public void handle(Void event) {
                                 if (r.succeeded()) {
                                     LOG.debugf("@OnBinaryMessage callback consumed text message: %s", connection);
                                 } else {
-                                    LOG.errorf(r.cause(), "Unable to consume text message in @OnBinaryMessage callback: %s",
+                                    logFailure(r.cause(), "Unable to consume binary message in @OnBinaryMessage callback",
                                             connection);
                                 }
                             });
@@ -210,8 +210,7 @@ public void handle(Void event) {
                             if (r.succeeded()) {
                                 LOG.debugf("@OnPongMessage callback consumed text message: %s", connection);
                             } else {
-                                LOG.errorf(r.cause(), "Unable to consume text message in @OnPongMessage callback: %s",
-                                        connection);
+                                logFailure(r.cause(), "Unable to consume text message in @OnPongMessage callback", connection);
                             }
                         });
                     });
@@ -226,7 +225,7 @@ public void handle(Void event) {
                                         if (r.succeeded()) {
                                             LOG.debugf("@OnClose callback completed: %s", connection);
                                         } else {
-                                            LOG.errorf(r.cause(), "Unable to complete @OnClose callback: %s", connection);
+                                            logFailure(r.cause(), "Unable to complete @OnClose callback", connection);
                                         }
                                         connectionManager.remove(generatedEndpointClass, connection);
                                     });
@@ -254,6 +253,29 @@ public void handle(Void event) {
         };
     }
 
+    private static void logFailure(Throwable throwable, String message, WebSocketConnection connection) {
+        if (isWebSocketIsClosedFailure(throwable)) {
+            LOG.debugf(throwable,
+                    message + ": %s",
+                    connection);
+        } else {
+            LOG.errorf(throwable,
+                    message + ": %s",
+                    connection);
+        }
+    }
+
+    private static boolean isWebSocketIsClosedFailure(Throwable throwable) {
+        if (throwable == null) {
+            return false;
+        }
+        String message = throwable.getMessage();
+        if (message == null) {
+            return false;
+        }
+        return message.contains("WebSocket is closed");
+    }
+
     private void textMessageHandler(WebSocketConnection connection, WebSocketEndpoint endpoint, ServerWebSocket ws,
             Context context, Consumer<String> textAction, boolean newDuplicatedContext) {
         ws.textMessageHandler(new Handler<String>() {

diff --git a/.../opentelemetry-scheduler/src/main/java/io/quarkus/it/opentelemetry/scheduler/Counter.java b/.../opentelemetry-scheduler/src/main/java/io/quarkus/it/opentelemetry/scheduler/Counter.java
@@ -23,6 +23,7 @@ public int get() {
 
     @Scheduled(cron = "*/1 * * * * ?", identity = "myCounter")
     void increment() throws InterruptedException {
+        System.out.println(Thread.currentThread().getName());
         Thread.sleep(100l);
         counter.incrementAndGet();
     }