Merge pull request #5347 from geoand/#5317

Ensure that the name of the generated Spring data repositories is unique
quarkusio · Nov 9, 2019 · 6abe1ad · 6abe1ad
2 parents c815b98 + e476a74
commit 6abe1ad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/...src/main/java/io/quarkus/spring/data/deployment/generate/SpringDataRepositoryCreator.java b/...src/main/java/io/quarkus/spring/data/deployment/generate/SpringDataRepositoryCreator.java
@@ -19,6 +19,7 @@
 import org.jboss.jandex.IndexView;
 import org.jboss.jandex.Type;
 
+import io.quarkus.deployment.util.HashUtil;
 import io.quarkus.deployment.util.JandexUtil;
 import io.quarkus.gizmo.ClassCreator;
 import io.quarkus.gizmo.ClassOutput;
@@ -73,10 +74,11 @@ public void implementCrudRepository(ClassInfo repositoryToImplement) {
         }
 
         Map<String, FieldDescriptor> fragmentImplNameToFieldDescriptor = new HashMap<>();
-        String generatedClassName = repositoryToImplement.name().toString() + "Impl";
+        String repositoryToImplementStr = repositoryToImplement.name().toString();
+        String generatedClassName = repositoryToImplementStr + "_" + HashUtil.sha1(repositoryToImplementStr) + "Impl";
         try (ClassCreator classCreator = ClassCreator.builder().classOutput(classOutput)
                 .className(generatedClassName)
-                .interfaces(repositoryToImplement.name().toString())
+                .interfaces(repositoryToImplementStr)
                 .build()) {
             classCreator.addAnnotation(ApplicationScoped.class);
 

diff --git a/...t/spring/data/jpa/PersonFragmentImpl.java → ...spring/data/jpa/PersonRepositoryImpl.java b/...t/spring/data/jpa/PersonFragmentImpl.java → ...spring/data/jpa/PersonRepositoryImpl.java
@@ -5,7 +5,7 @@
 import javax.persistence.EntityManager;
 import javax.persistence.PersistenceContext;
 
-public class PersonFragmentImpl implements PersonFragment, PersonFragment2 {
+public class PersonRepositoryImpl implements PersonFragment, PersonFragment2 {
 
     @PersistenceContext
     EntityManager entityManager;