Skip to content

Commit

Permalink
Use Collection instead of forcing to List
Browse files Browse the repository at this point in the history
  • Loading branch information
gastaldi committed Jun 5, 2020
1 parent 2a463d1 commit 7a5efed
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ void build(BuildProducer<FeatureBuildItem> featureProducer,
Set<Class<?>> javaMigrationClasses = new HashSet<>();
addJavaMigrations(combinedIndexBuildItem.getIndex().getAllKnownImplementors(JAVA_MIGRATION), context,
reflectiveClassProducer, javaMigrationClasses);
recorder.setApplicationMigrationClasses(new ArrayList<>(javaMigrationClasses));
recorder.setApplicationMigrationClasses(javaMigrationClasses);

resourceProducer.produce(new NativeImageResourceBuildItem(applicationMigrations.toArray(new String[0])));
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.quarkus.flyway.runtime;

import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import java.util.function.Supplier;

Expand All @@ -20,12 +21,12 @@ public class FlywayRecorder {

private final List<FlywayContainer> flywayContainers = new ArrayList<>(2);

public void setApplicationMigrationFiles(List<String> migrationFiles) {
public void setApplicationMigrationFiles(Collection<String> migrationFiles) {
log.debugv("Setting the following application migration files: {0}", migrationFiles);
QuarkusPathLocationScanner.setApplicationMigrationFiles(migrationFiles);
}

public void setApplicationMigrationClasses(List<Class<?>> migrationClasses) {
public void setApplicationMigrationClasses(Collection<Class<?>> migrationClasses) {
log.debugv("Setting the following application migration classes: {0}", migrationClasses);
QuarkusPathLocationScanner.setApplicationMigrationClasses(migrationClasses);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;

import org.flywaydb.core.api.Location;
import org.flywaydb.core.internal.resource.LoadableResource;
Expand All @@ -19,8 +18,8 @@
public final class QuarkusPathLocationScanner implements ResourceAndClassScanner {
private static final Logger LOGGER = Logger.getLogger(QuarkusPathLocationScanner.class);
private static final String LOCATION_SEPARATOR = "/";
private static List<String> applicationMigrationFiles;
private static List<Class<?>> applicationMigrationClasses;
private static Collection<String> applicationMigrationFiles;
private static Collection<Class<?>> applicationMigrationClasses;

private final Collection<LoadableResource> scannedResources;

Expand Down Expand Up @@ -77,11 +76,11 @@ public Collection<Class<?>> scanForClasses() {
return applicationMigrationClasses;
}

public static void setApplicationMigrationFiles(List<String> applicationMigrationFiles) {
public static void setApplicationMigrationFiles(Collection<String> applicationMigrationFiles) {
QuarkusPathLocationScanner.applicationMigrationFiles = applicationMigrationFiles;
}

public static void setApplicationMigrationClasses(List<Class<?>> applicationMigrationClasses) {
public static void setApplicationMigrationClasses(Collection<Class<?>> applicationMigrationClasses) {
QuarkusPathLocationScanner.applicationMigrationClasses = applicationMigrationClasses;
}
}

0 comments on commit 7a5efed

Please sign in to comment.