Merge pull request #27737 from sberyozkin/resteasy_reactive_statustyp…

…e_equals Add RESTEasy Reactive StatusType equals and hashCode methods
quarkusio · Sep 7, 2022 · 83b3699 · 83b3699
2 parents 1aa2224 + 6d6574e
commit 83b3699
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 1 deletion.
diff --git a/...common/runtime/src/main/java/org/jboss/resteasy/reactive/common/jaxrs/StatusTypeImpl.java b/...common/runtime/src/main/java/org/jboss/resteasy/reactive/common/jaxrs/StatusTypeImpl.java
@@ -1,5 +1,6 @@
 package org.jboss.resteasy.reactive.common.jaxrs;
 
+import java.util.Objects;
 import javax.ws.rs.core.Response;
 import javax.ws.rs.core.Response.Status.Family;
 import javax.ws.rs.core.Response.StatusType;
@@ -13,7 +14,16 @@ public class StatusTypeImpl implements StatusType {
 
     public StatusTypeImpl(int status, String reasonPhrase) {
         this.status = status;
-        this.reasonPhrase = reasonPhrase != null ? reasonPhrase : DEFAULT_REASON_PHRASE;
+        this.reasonPhrase = reasonPhrase != null ? reasonPhrase : getDefaultReasonPhrase(status);
+    }
+
+    private static String getDefaultReasonPhrase(int providedStatus) {
+        for (Response.Status defaultStatus : Response.Status.values()) {
+            if (providedStatus == defaultStatus.getStatusCode()) {
+                return defaultStatus.getReasonPhrase() != null ? defaultStatus.getReasonPhrase() : DEFAULT_REASON_PHRASE;
+            }
+        }
+        return DEFAULT_REASON_PHRASE;
     }
 
     @Override
@@ -31,6 +41,20 @@ public String getReasonPhrase() {
         return reasonPhrase;
     }
 
+    @Override
+    public boolean equals(Object other) {
+        if (!(other instanceof StatusType)) {
+            return false;
+        }
+        return this.status == ((StatusType) other).getStatusCode()
+                && this.reasonPhrase.equals(((StatusType) other).getReasonPhrase());
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hashCode(status) + 37 * reasonPhrase.hashCode();
+    }
+
     public static StatusTypeImpl valueOf(StatusType statusType) {
         if (statusType instanceof StatusTypeImpl)
             return (StatusTypeImpl) statusType;

diff --git a/...on/runtime/src/test/java/org/jboss/resteasy/reactive/common/jaxrs/StatusTypeImplTest.java b/...on/runtime/src/test/java/org/jboss/resteasy/reactive/common/jaxrs/StatusTypeImplTest.java
@@ -0,0 +1,21 @@
+package org.jboss.resteasy.reactive.common.jaxrs;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+
+import javax.ws.rs.core.Response;
+import org.junit.jupiter.api.Test;
+
+public class StatusTypeImplTest {
+    @Test
+    public void testEquals() {
+        Response.StatusType statusType = new StatusTypeImpl(200, null);
+        assertEquals(statusType, Response.Status.OK);
+    }
+
+    @Test
+    public void testNotEquals() {
+        Response.StatusType statusType = new StatusTypeImpl(200, "All works OK");
+        assertNotEquals(statusType, Response.Status.OK);
+    }
+}