Merge pull request #7523 from jaikiran/pr-7521

Load JSON parent first for logging
quarkusio · Mar 3, 2020 · 9c009c0 · 9c009c0
2 parents 3fbdbc3 + 2f3c1df
commit 9c009c0
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java b/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java
@@ -31,6 +31,7 @@
 import java.util.zip.ZipEntry;
 import java.util.zip.ZipOutputStream;
 
+import org.apache.maven.artifact.Artifact;
 import org.apache.maven.execution.MavenSession;
 import org.apache.maven.model.Dependency;
 import org.apache.maven.model.Plugin;
@@ -603,6 +604,12 @@ void prepare() throws Exception {
 
             addToClassPaths(classPathManifest, devModeContext, wiringClassesDirectory);
 
+            //in most cases these are not used, however they need to be present for some
+            //parent-first cases such as logging
+            for (Artifact appDep : project.getArtifacts()) {
+                addToClassPaths(classPathManifest, devModeContext, appDep.getFile());
+            }
+
             //we also want to add the maven plugin jar to the class path
             //this allows us to just directly use classes, without messing around copying them
             //to the runner jar

diff --git a/extensions/jsonp/runtime/pom.xml b/extensions/jsonp/runtime/pom.xml
@@ -34,6 +34,10 @@
                         <excludedArtifact>javax.json:javax.json-api</excludedArtifact>
                         <excludedArtifact>org.glassfish:javax.json</excludedArtifact>
                     </excludedArtifacts>
+                    <parentFirstArtifacts>
+                        <parentFirstArtifact>org.glassfish:jakarta.json</parentFirstArtifact>
+                        <parentFirstArtifact>jakarta.json:jakarta.json-api</parentFirstArtifact>
+                    </parentFirstArtifacts>
                 </configuration>
             </plugin>
             <plugin>

diff --git a/integration-tests/maven/src/test/resources/projects/classic-noconfig/pom.xml b/integration-tests/maven/src/test/resources/projects/classic-noconfig/pom.xml
@@ -34,6 +34,12 @@
       <groupId>io.quarkus</groupId>
       <artifactId>quarkus-undertow-websockets</artifactId>
     </dependency>
+    <!-- quarkus-logging-json dependency to make sure application start
+ doesn't fail in dev mode due to classloading issues (see issue#7469) -->
+    <dependency>
+      <groupId>io.quarkus</groupId>
+      <artifactId>quarkus-logging-json</artifactId>
+    </dependency>
     <dependency>
       <groupId>org.webjars</groupId>
       <artifactId>bootstrap</artifactId>