Skip to content

Commit

Permalink
Only include bootstrap dependencies in quarkus:dev ClassPath
Browse files Browse the repository at this point in the history
The rest of the depenencies are resolved in the bootstrap resolver,
having them on the ClassPath only causes problems.

A similar fix could be applied to Gradle, however I am not sure
how to filter the dependencies to only include those required
for bootstrap.

Fixes #12136
  • Loading branch information
stuartwdouglas committed Sep 17, 2020
1 parent bff1662 commit c65599f
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java
Original file line number Diff line number Diff line change
Expand Up @@ -710,17 +710,6 @@ void prepare(final boolean triggerCompile) throws Exception {

args.add("-Djava.util.logging.manager=org.jboss.logmanager.LogManager");

//in most cases these are not used, however they need to be present for some
//parent-first cases such as logging
for (Artifact appDep : project.getArtifacts()) {
// only add the artifact if it's present in the dev mode context
// we need this to avoid having jars on the classpath multiple times
if (!devModeContext.getLocalArtifacts().contains(new AppArtifactKey(appDep.getGroupId(), appDep.getArtifactId(),
appDep.getClassifier(), appDep.getArtifactHandler().getExtension()))) {
addToClassPaths(classPathManifest, appDep.getFile());
}
}

//now we need to build a temporary jar to actually run

File tempFile = new File(buildDir, project.getArtifactId() + "-dev.jar");
Expand Down

0 comments on commit c65599f

Please sign in to comment.