Skip to content

Commit

Permalink
Merge pull request #8497 from ShubhamRwt/Fixes
Browse files Browse the repository at this point in the history
Easy Config-related cleanups #5388
  • Loading branch information
machi1990 authored Apr 24, 2020
2 parents 734706b + c36f2ad commit ce8bd8c
Show file tree
Hide file tree
Showing 36 changed files with 71 additions and 71 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ public class NativeConfig {
/**
* If the HTTPS url handler should be enabled, allowing you to do URL.openConnection() for HTTPS URLs
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean enableHttpsUrlHandler;

/**
* If all security services should be added to the native image
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean enableAllSecurityServices;

/**
Expand All @@ -46,13 +46,13 @@ public class NativeConfig {
/**
* If all character sets should be added to the native image. This increases image size
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean addAllCharsets;

/**
* If all time zones should be added to the native image. This increases image size
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean includeAllTimeZones;

/**
Expand All @@ -76,14 +76,14 @@ public class NativeConfig {
/**
* If debug symbols should be included
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean debugSymbols;

/**
* If the native image build should wait for a debugger to be attached before running. This is an advanced option
* and is generally only intended for those familiar with GraalVM internals
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean debugBuildProcess;

/**
Expand All @@ -95,7 +95,7 @@ public class NativeConfig {
/**
* If the native image server should be restarted
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean cleanupServer;

/**
Expand All @@ -108,33 +108,33 @@ public class NativeConfig {
* If a JVM based 'fallback image' should be created if native image fails. This is not recommended, as this is
* functionally the same as just running the application in a JVM
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean enableFallbackImages;

/**
* If the native image server should be used. This can speed up compilation but can result in changes not always
* being picked up due to cache invalidation not working 100%
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean enableServer;

/**
* If all META-INF/services entries should be automatically registered
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean autoServiceLoaderRegistration;

/**
* If the bytecode of all proxies should be dumped for inspection
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean dumpProxies;

/**
* If this build should be done using a container runtime. If this is set docker will be used by default,
* unless container-runtime is also set.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean containerBuild;

/**
Expand All @@ -159,7 +159,7 @@ public class NativeConfig {
/**
* If the resulting image should allow VM introspection
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean enableVmInspection;

/**
Expand All @@ -171,7 +171,7 @@ public class NativeConfig {
/**
* If the reports on call paths and included packages/classes/methods should be generated
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean enableReports;

/**
Expand All @@ -185,7 +185,7 @@ public class NativeConfig {
* means
* your application may fail at runtime if an unsupported feature is used by accident.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean reportErrorsAtRuntime;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class PackageConfig {
/**
* If the java runner should be packed as an uberjar
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean uberJar;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public class ThreadPoolConfig {
* threads beyond the core size should be created as aggressively as threads within it; a value of {@code 1.0f}
* implies that threads beyond the core size should never be created.
*/
@ConfigItem(defaultValue = "0")
@ConfigItem
public float growthResistance;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class DataSourceJdbcRuntimeConfig {
/**
* The datasource pool minimum size
*/
@ConfigItem(defaultValue = "0")
@ConfigItem
public int minSize = 0;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class LegacyDataSourceJdbcRuntimeConfig {
/**
* @deprecated use quarkus.datasource.jdbc.min-size instead.
*/
@ConfigItem(defaultValue = "0")
@ConfigItem
@Deprecated
public int minSize = 0;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public class NettyHttpClientConfig {
* <p>
* 0 means unlimited.
*/
@ConfigItem(defaultValue = "0")
@ConfigItem
public int maxHttp2Streams;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,18 @@ public class ContainerImageConfig {
/**
* Whether or not insecure registries are allowed
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean insecure;

/**
* Whether or not a image build will be performed.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean build;

/**
* Whether or not an image push will be performed.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean push;
}
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class DataSourcesBuildTimeConfig {
* NOTE: This is different from the "jdbc.enable-metrics" property that needs to be set on the JDBC datasource level to
* enable collection of metrics for that datasource.
*/
@ConfigItem(name = "metrics.enabled", defaultValue = "false")
@ConfigItem(name = "metrics.enabled")
public boolean metricsEnabled;

}
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public class HibernateOrmConfig {
/**
* Whether or not metrics are published in case the smallrye-metrics extension is present (default to false).
*/
@ConfigItem(name = "metrics.enabled", defaultValue = "false")
@ConfigItem(name = "metrics.enabled")
public boolean metricsEnabled;

/**
Expand Down Expand Up @@ -212,7 +212,7 @@ public static class HibernateOrmConfigDatabase {
/**
* Whether we should stop on the first error when applying the schema.
*/
@ConfigItem(name = "generation.halt-on-error", defaultValue = "false")
@ConfigItem(name = "generation.halt-on-error")
public boolean generationHaltOnError;

/**
Expand All @@ -236,7 +236,7 @@ public static class HibernateOrmConfigDatabase {
/**
* Whether Hibernate should quote all identifiers.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean globallyQuotedIdentifiers;

public boolean isAnyPropertySet() {
Expand Down Expand Up @@ -281,15 +281,15 @@ public static class HibernateOrmConfigLog {
* <p>
* Setting it to true is obviously not recommended in production.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean sql;

/**
* Logs SQL bind parameter.
* <p>
* Setting it to true is obviously not recommended in production.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean bindParam;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ public static class DiscoveryConfig {
/**
* Defines if automatic discovery is enabled.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
boolean enabled;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class InfinispanClientBuildTimeConfig {
/**
* Sets the bounded entry count for near cache. If this value is 0 or less near cache is disabled.
*/
@ConfigItem(defaultValue = "0")
@ConfigItem
public int nearCacheMaxEntries;

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class KubernetesClientBuildConfig {
/**
* Whether or not the client should trust a self signed certificate if so presented by the API server
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean trustCerts;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public class AwsElasticBlockStoreVolumeConfig {
/**
* Wether the volumeName is read only or not.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
boolean readOnly;

}
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public enum Kind {
/**
* Wether the volumeName is read only or not.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
boolean readOnly;

}
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class AzureFileVolumeConfig {
/**
* Wether the volumeName is read only or not.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
boolean readOnly;

}
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class ConfigMapVolumeConfig {
/**
* Optional
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
boolean optional;

}
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ public class KubernetesConfig implements PlatformConfiguration {
/**
* If true, a Kubernetes Ingress will be created
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
boolean expose;

public Optional<String> getPartOf() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ public class MountConfig {
*
* @return True if mount is readonly, False otherwise.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
boolean readOnly;
}
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ public class OpenshiftConfig implements PlatformConfiguration {
/**
* If true, an Openshift Route will be created
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
boolean expose;

public Optional<String> getPartOf() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ public class PvcVolumeConfig {
/**
* Optional
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
boolean optional;
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ public class SecretVolumeConfig {
/**
* Optional
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
boolean optional;
}
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public class GelfConfig {
* Negative throwable reference walk the exception chain from the root cause side: -1 will extract the root cause,
* -2 the exception wrapping the root cause, ...
*/
@ConfigItem(defaultValue = "0")
@ConfigItem
public int stackTraceThrowableReference;

/**
Expand Down Expand Up @@ -96,6 +96,6 @@ public class GelfConfig {
/**
* Whether to include all fields from the MDC.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean includeFullMdc;
}
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,13 @@ public class MongoClientConfig {
/**
* If connecting with TLS, this option enables insecure TLS connections.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean tlsInsecure;

/**
* Whether to connect using TLS.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean tls;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class WriteConcernConfig {
/**
* If set to {@code true}, the driver will retry supported write operations if they fail due to a network error.
*/
@ConfigItem(defaultValue = "false")
@ConfigItem
public boolean retryWrites;

/**
Expand Down
Loading

0 comments on commit ce8bd8c

Please sign in to comment.