invert order of parameters and make minChunSize final

quarkusio · May 29, 2023 · cecc9c4 · cecc9c4
1 parent 7bf38a3
commit cecc9c4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/...ive/server/vertx/src/main/java/org/jboss/resteasy/reactive/server/vertx/AppendBuffer.java b/...ive/server/vertx/src/main/java/org/jboss/resteasy/reactive/server/vertx/AppendBuffer.java
@@ -13,16 +13,17 @@
  */
 final class AppendBuffer {
     private final ByteBufAllocator allocator;
+
+    private final int minChunkSize;
     private final int capacity;
     private ByteBuf buffer;
     private ArrayDeque<ByteBuf> otherBuffers;
     private int size;
-    private int minChunkSize;
 
-    private AppendBuffer(ByteBufAllocator allocator, int capacity, int minChunkSize) {
+    private AppendBuffer(ByteBufAllocator allocator, int minChunkSize, int capacity) {
         this.allocator = allocator;
-        this.capacity = capacity;
         this.minChunkSize = Math.min(minChunkSize, capacity);
+        this.capacity = capacity;
     }
 
     /**
@@ -37,16 +38,16 @@ public static AppendBuffer eager(ByteBufAllocator allocator, int capacity) {
      * The data is consolidated in a single {@link CompositeByteBuf} on {@link #clear}.
      */
     public static AppendBuffer exact(ByteBufAllocator allocator, int capacity) {
-        return new AppendBuffer(allocator, capacity, 0);
+        return new AppendBuffer(allocator, 0, capacity);
     }
 
     /**
      * This buffer append data in multiples {@link ByteBuf}s which minimum capacity is {@code minChunkSize} or
      * as each {@code len}, if greater than it.<br>
      * The data is consolidated in a single {@link CompositeByteBuf} on {@link #clear}.
      */
-    public static AppendBuffer withMinChunks(ByteBufAllocator allocator, int capacity, int minChunkSize) {
-        return new AppendBuffer(allocator, capacity, minChunkSize);
+    public static AppendBuffer withMinChunks(ByteBufAllocator allocator, int minChunkSize, int capacity) {
+        return new AppendBuffer(allocator, minChunkSize, capacity);
     }
 
     private ByteBuf lastBuffer() {

diff --git a/.../src/main/java/org/jboss/resteasy/reactive/server/vertx/ResteasyReactiveOutputStream.java b/.../src/main/java/org/jboss/resteasy/reactive/server/vertx/ResteasyReactiveOutputStream.java
@@ -40,8 +40,8 @@ public class ResteasyReactiveOutputStream extends OutputStream {
     public ResteasyReactiveOutputStream(VertxResteasyReactiveRequestContext context) {
         this.context = context;
         this.request = context.getContext().request();
-        this.appendBuffer = AppendBuffer.withMinChunks(PooledByteBufAllocator.DEFAULT,
-                context.getDeployment().getResteasyReactiveConfig().getOutputBufferSize(), DEFAULT_MIN_CHUNK_SIZE);
+        this.appendBuffer = AppendBuffer.withMinChunks(PooledByteBufAllocator.DEFAULT, DEFAULT_MIN_CHUNK_SIZE,
+                context.getDeployment().getResteasyReactiveConfig().getOutputBufferSize());
         request.response().exceptionHandler(new Handler<Throwable>() {
             @Override
             public void handle(Throwable event) {