Merge pull request #12674 from mkouba/issue-12671

Fix NPE in AsmUtilCopy
quarkusio · Oct 13, 2020 · db8cb59 · db8cb59
2 parents 6dbb79f + 860b1a1
commit db8cb59
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/AsmUtilCopy.java b/independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/AsmUtilCopy.java
@@ -258,6 +258,9 @@ public static boolean needsSignature(MethodInfo method) {
      * Returns true if the given type contains parameterized types, type variables or wildcards
      */
     private static boolean needsSignature(Type type) {
+        if (type == null) {
+            return false;
+        }
         switch (type.kind()) {
             case ARRAY:
             case CLASS:

diff --git a/...endent-projects/arc/processor/src/test/java/io/quarkus/arc/processor/AsmUtilCopyTest.java b/...endent-projects/arc/processor/src/test/java/io/quarkus/arc/processor/AsmUtilCopyTest.java
@@ -0,0 +1,15 @@
+package io.quarkus.arc.processor;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+
+import java.io.IOException;
+import org.junit.jupiter.api.Test;
+
+public class AsmUtilCopyTest {
+
+    @Test
+    public void testNeedsSignature() throws IOException {
+        assertFalse(AsmUtilCopy.needsSignature(Basics.index(Object.class).getClassByName(DotNames.OBJECT)));
+    }
+
+}