Some test fixes to improve test suite stability

test-framework/arquillian/src/main/java/io/quarkus/arquillian/QuarkusDeployableContainer.java

@@ -198,7 +198,10 @@ public void execute(BuildContext context) {
         }
 
         ProtocolMetaData metadata = new ProtocolMetaData();
-        URI uri = URI.create(TestHTTPResourceManager.getUri());
+
+        String testUri = TestHTTPResourceManager.getUri();
+        System.setProperty("test.url", testUri);
+        URI uri = URI.create(testUri);
         HTTPContext httpContext = new HTTPContext(uri.getHost(), uri.getPort());
         // This is to work around https://github.com/arquillian/arquillian-core/issues/216
         httpContext.add(new Servlet("dummy", "/"));

test-framework/common/src/main/java/io/quarkus/test/common/NativeImageLauncher.java

@@ -51,6 +51,8 @@ public NativeImageLauncher(Class<?> testClass, int port, long imageWaitTime) {
 
     public void start() throws IOException {
 
+        System.setProperty("test.url", TestHTTPResourceManager.getUri());
+
         String path = System.getProperty("native.image.path");
         if (path == null) {
             path = guessPath(testClass);

test-framework/common/src/main/java/io/quarkus/test/common/http/TestHTTPResourceManager.java

@@ -17,9 +17,7 @@ public static String getUri() {
         String host = config.getOptionalValue("quarkus.http.host", String.class).orElse("localhost");
         String port = config.getOptionalValue("quarkus.http.test-port", String.class).orElse("8081");
         String contextPath = config.getOptionalValue("quarkus.servlet.context-path", String.class).orElse("");
-        String testUrl = "http://" + host + ":" + port + contextPath;
-        System.setProperty("test.url", testUrl);
-        return testUrl;
+        return "http://" + host + ":" + port + contextPath;
     }
 
     public static void inject(Object testCase) {

test-framework/junit5-internal/src/main/java/io/quarkus/test/QuarkusDevModeTest.java

@@ -339,15 +339,18 @@ void modifyFile(String name, Function<String, String> mutator, Path path) {
     }
 
     public void sleepForFileChanges(Path path) {
-        long currentTime = System.currentTimeMillis();
         try {
+            //we want to make sure the last modified time is larger than both the current time
+            //and the current last modified time. Some file systems only resolve file
+            //time to the nearest second, so this is necessary for dev mode to pick up the changes
+            long timeToBeat = Math.max(System.currentTimeMillis(), Files.getLastModifiedTime(path).toMillis());
             for (;;) {
                 Files.setLastModifiedTime(path, FileTime.fromMillis(System.currentTimeMillis()));
                 long fm = Files.getLastModifiedTime(path).toMillis();
-                if (fm > currentTime) {
+                Thread.sleep(10);
+                if (fm > timeToBeat) {
                     return;
                 }
-                Thread.sleep(50);
             }
         } catch (Exception e) {
             throw new RuntimeException(e);

test-framework/junit5-internal/src/main/java/io/quarkus/test/QuarkusUnitTest.java

@@ -273,6 +273,7 @@ public void execute(BuildContext context) {
                     fail("The build was expected to fail");
                 }
                 started = true;
+                System.setProperty("test.url", TestHTTPResourceManager.getUri());
                 Instance<?> factory;
                 try {
                     factory = CDI.current()

test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java

@@ -228,6 +228,8 @@ public void execute(BuildContext context) {
                 .build();
         runtimeRunner.run();
 
+        System.setProperty("test.url", TestHTTPResourceManager.getUri());
+
         Closeable shutdownTask = new Closeable() {
             @Override
             public void close() throws IOException {