Skip to content

Commit

Permalink
Merge pull request #25577 from franz1981/no_listners_on_end
Browse files Browse the repository at this point in the history
No need to use response methods returning a Future, if not used
  • Loading branch information
Sanne authored May 14, 2022
2 parents b9c4450 + 4881220 commit e731570
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ public ServerHttpResponse setStatusCode(int code) {
@Override
public ServerHttpResponse end() {
if (!response.ended()) {
response.end();
response.end((Handler<AsyncResult<Void>>) null);
}
return this;
}
Expand All @@ -340,13 +340,13 @@ public boolean headWritten() {

@Override
public ServerHttpResponse end(byte[] data) {
response.end(Buffer.buffer(data));
response.end(Buffer.buffer(data), null);
return this;
}

@Override
public ServerHttpResponse end(String data) {
response.end(data);
response.end(Buffer.buffer(data), null);
return this;
}

Expand Down

0 comments on commit e731570

Please sign in to comment.