-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No options to scale gRPC server #10057
Comments
I believe there is a TODO in the code explaining that the server should be started in a verticle and the number of verticles should be configurable. |
michalszynkiewicz
added a commit
to michalszynkiewicz/quarkus
that referenced
this issue
Jun 24, 2020
michalszynkiewicz
added a commit
to michalszynkiewicz/quarkus
that referenced
this issue
Jun 24, 2020
michalszynkiewicz
added a commit
to michalszynkiewicz/quarkus
that referenced
this issue
Jun 25, 2020
michalszynkiewicz
added a commit
to michalszynkiewicz/quarkus
that referenced
this issue
Jun 25, 2020
michalszynkiewicz
added a commit
to michalszynkiewicz/quarkus
that referenced
this issue
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
io.vertx.grpc.VertxServer
do not auto-scale across Vert.x event-loop. In Vert.x the scaling is determined by the number of deployed instances of a Verticles. I am not entirely familiar with how Quarkus initializes theGrpcServerRecorder
, but it seems like only one instance ofVertxServer
is ever started.Expected behavior
Singletons implementing a gRPC Service should be allowed to scale across Vert.x event-loop. Additionally, provide a way to configure the desired scaling.
Actual behavior
At most 2 Vert.x event loop threads process request for
VertxServer
To Reproduce
Steps to reproduce the behavior:
@Singleton
and extendingMutinyApiConfigServiceGrpc.[GrpcServiceName]ImplBase
vert.x-eventloop-thread-
.Configuration
No additional configuration were provided. gRPC extension was using the default values.
Environment (please complete the following information):
uname -a
orver
:java -version
:mvnw --version
orgradlew --version
):Additional context
io.quarkus.grpc.runtime.GrpcServerRecorder
has the following comment on line 62The text was updated successfully, but these errors were encountered: