Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop resolving workspace #10549

Closed
stuartwdouglas opened this issue Jul 8, 2020 · 0 comments · Fixed by #10576
Closed

Infinite loop resolving workspace #10549

stuartwdouglas opened this issue Jul 8, 2020 · 0 comments · Fixed by #10576
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@stuartwdouglas
Copy link
Member

If you take the reproducer from #5879 and update the quarkus version to the latest version you will get an infinite loop when running mvn quarkus:dev.

This project has an odd structure, where the parent is not the top level project.

The issue is in this code here:

Reading the model will correctly follow the parent references to get to the correct parent, but then it looks in the top level directory again, and will restart the cycle. I am not really sure what the correct fix is here, because I don't know why that logic was added.

Also this code seems inefficient, if we have parsed the model shouldn't we be saving it somewhere so we don't need to re-parse it when loading the workspace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants