Bootstrap workspace discovery: fix infinite loop, pom model cache #10576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area/devtools
gastaldi
reviewed
Jul 8, 2020
...maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalProject.java
Outdated
Show resolved
Hide resolved
gastaldi
approved these changes
Jul 8, 2020
stuartwdouglas
approved these changes
Jul 8, 2020
|
@aloubyansky do you think this is safe enough to backport? I am kinda on the fence about it, the inifite loop is nasty but it has only come up once that we have seen so I don't think it is super common. The reduced parsing of pom files might be nice though. |
|
I have pretty much the same feeling. I think I would have backported this primarily to fix the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10549