SSL support for reactive DB2 client

[tsegismont]

SSL is supported upstream

[quarkusbot]

/cc @aguibert

[aguibert]

I think we can close this issue, Vertx 3.9.1 actually supports DB2 with SSL just fine, it's just that I didn't get around to testing it until 3.9.2 (no code changes were needed, just added a test)

[tsegismont]

@aguibert indeed, tests left aside, eclipse-vertx/vertx-sql-client#679 only improves usability by adding methods to DB2ConnectOptions.

But upstream support is not enough. Among other things, the pool recorder must be updated (Postgres here):

quarkus/extensions/reactive-pg-client/runtime/src/main/java/io/quarkus/reactive/pg/client/runtime/PgPoolRecorder.java

Lines 139 to 151 in 4fa78b0

	if (dataSourceReactivePostgreSQLConfig.sslMode.isPresent()) {
	pgConnectOptions.setSslMode(dataSourceReactivePostgreSQLConfig.sslMode.get());
	}
	pgConnectOptions.setTrustAll(dataSourceReactiveRuntimeConfig.trustAll);
	configurePemTrustOptions(pgConnectOptions, dataSourceReactiveRuntimeConfig.trustCertificatePem);
	configureJksTrustOptions(pgConnectOptions, dataSourceReactiveRuntimeConfig.trustCertificateJks);
	configurePfxTrustOptions(pgConnectOptions, dataSourceReactiveRuntimeConfig.trustCertificatePfx);
	configurePemKeyCertOptions(pgConnectOptions, dataSourceReactiveRuntimeConfig.keyCertificatePem);
	configureJksKeyCertOptions(pgConnectOptions, dataSourceReactiveRuntimeConfig.keyCertificateJks);
	configurePfxKeyCertOptions(pgConnectOptions, dataSourceReactiveRuntimeConfig.keyCertificatePfx);

This is missing for DB2:

quarkus/extensions/reactive-db2-client/runtime/src/main/java/io/quarkus/reactive/db2/client/runtime/DB2PoolRecorder.java

Lines 65 to 110 in 4fa78b0

	private DB2ConnectOptions toConnectOptions(DataSourceRuntimeConfig dataSourceRuntimeConfig,
	DataSourceReactiveRuntimeConfig dataSourceReactiveRuntimeConfig,
	DataSourceReactiveDB2Config dataSourceReactiveDB2Config) {
	DB2ConnectOptions connectOptions;
	if (dataSourceReactiveRuntimeConfig.url.isPresent()) {
	String url = dataSourceReactiveRuntimeConfig.url.get();
	// clean up the URL to make migrations easier
	if (url.matches("^vertx-reactive:db2://.*$")) {
	url = url.substring("vertx-reactive:".length());
	}
	connectOptions = DB2ConnectOptions.fromUri(url);
	} else {
	connectOptions = new DB2ConnectOptions();
	}
	if (dataSourceRuntimeConfig.username.isPresent()) {
	connectOptions.setUser(dataSourceRuntimeConfig.username.get());
	}
	if (dataSourceRuntimeConfig.password.isPresent()) {
	connectOptions.setPassword(dataSourceRuntimeConfig.password.get());
	}
	// credentials provider
	if (dataSourceRuntimeConfig.credentialsProvider.isPresent()) {
	String beanName = dataSourceRuntimeConfig.credentialsProviderName.orElse(null);
	CredentialsProvider credentialsProvider = CredentialsProviderFinder.find(beanName);
	String name = dataSourceRuntimeConfig.credentialsProvider.get();
	Map<String, String> credentials = credentialsProvider.getCredentials(name);
	String user = credentials.get(USER_PROPERTY_NAME);
	String password = credentials.get(PASSWORD_PROPERTY_NAME);
	if (user != null) {
	connectOptions.setUser(user);
	}
	if (password != null) {
	connectOptions.setPassword(user);
	}
	}
	if (dataSourceReactiveDB2Config.cachePreparedStatements.isPresent()) {
	connectOptions.setCachePreparedStatements(dataSourceReactiveDB2Config.cachePreparedStatements.get());
	}
	return connectOptions;
	}

So this issue should stay open, although it actually does not depend on #9480