Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC AnnotationStore - AnnotationTarget is incorrectly used as a key in a Map #10593

Closed
mkouba opened this issue Jul 9, 2020 · 1 comment · Fixed by #10598
Closed

ArC AnnotationStore - AnnotationTarget is incorrectly used as a key in a Map #10593

mkouba opened this issue Jul 9, 2020 · 1 comment · Fixed by #10598
Assignees
@mkouba
Labels
area/arc Issue related to ARC (dependency injection) kind/bug Something isn't working
Milestone
1.6.1.Final

Comments

@mkouba
Copy link
Contributor

mkouba commented Jul 9, 2020

ClassInfo and FieldInfo do not override equals()/hashCode(). Moreover, new FieldInfo objects are created for each ClassInfo.fields() invocation.
@mkouba mkouba added kind/bug Something isn't working area/arc Issue related to ARC (dependency injection) labels Jul 9, 2020
@mkouba
Copy link
Contributor Author

mkouba commented Jul 9, 2020

As a consequence the annotation transformers may be called multiple times for the same field (but different FieldInfos). The result should be the same though. It shouldn't be a problem for methods (because MethodInfo overrides equals/hashCode). Also object identity should work fine for ClassInfo.

@mkouba mkouba self-assigned this Jul 9, 2020
@mkouba mkouba added this to the 1.7.0 - master milestone Jul 9, 2020
mkouba added a commit to mkouba/quarkus that referenced this issue Jul 9, 2020
@mkouba
ArC - fix AnnotationStore
2f42ce9 
- AnnotationTarget was incorrectly used as a key in a Map
- resolves quarkusio#10593
@mkouba mkouba mentioned this issue Jul 9, 2020
Merged
mkouba added a commit to mkouba/quarkus that referenced this issue Jul 10, 2020
@mkouba
ArC - fix AnnotationStore
7f33d1e 
- AnnotationTarget was incorrectly used as a key in a Map
- resolves quarkusio#10593
@gsmet gsmet modified the milestones: 1.7.0 - master, 1.6.1.Final Jul 16, 2020
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jul 16, 2020
@mkouba @gsmet
ArC - fix AnnotationStore
5c77c06 
- AnnotationTarget was incorrectly used as a key in a Map
- resolves quarkusio#10593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkouba mkouba

Labels
area/arc Issue related to ARC (dependency injection) kind/bug Something isn't working
Projects
None yet
Milestone
1.6.1.Final
Development

Successfully merging a pull request may close this issue.

ArC - fix AnnotationStore mkouba/quarkus
2 participants
@mkouba @gsmet