Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openapi ignores quarkus.resteasy.path in Quarkus 1.6.0.Final #10616

Closed
crissi98 opened this issue Jul 9, 2020 · 6 comments
Closed

Openapi ignores quarkus.resteasy.path in Quarkus 1.6.0.Final #10616

crissi98 opened this issue Jul 9, 2020 · 6 comments
Assignees
Labels
area/openapi kind/bug Something isn't working
Milestone

Comments

@crissi98
Copy link

crissi98 commented Jul 9, 2020

Describe the bug
OpenApi ignores the quarkus.resteasy.path-Property for constructing of openapi.yaml. So, when you set the property, all of the paths generated in the openapi-specification are missing it.

Expected behavior
The yaml should look like this:

openapi: 3.0.1
info:
  title: Generated API
  version: "1.0"
paths:
  /test/hello:
    get:
      responses:
        ...

Actual behavior
The yaml looks like this

openapi: 3.0.1
info:
  title: Generated API
  version: "1.0"
paths:
  /hello:
    get:
      responses:
        ...

To Reproduce
Project to reproduce:
openapi-path-demo.zip

Configuration

# Add your application.properties here, if applicable.
quarkus.resteasy.path=/test

Additional context
I know that you don´t want openapi to be dependent on quarkus-resteasy as described in #8407, but I in my opinion the path
sould be used if it is specified.
A solution to that could be to add the path again in https://github.com/quarkusio/quarkus/blob/master/extensions/smallrye-openapi/deployment/src/main/java/io/quarkus/smallrye/openapi/deployment/RESTEasyExtension.java but this time without using the ResteasyJaxrsConfigBuildItem, so you are not dependend on quarkus-resteasy.

@crissi98 crissi98 added the kind/bug Something isn't working label Jul 9, 2020
@quarkusbot
Copy link

@phillip-kruger
Copy link
Member

I'll look at this.

@phillip-kruger phillip-kruger self-assigned this Jul 9, 2020
@crissi98
Copy link
Author

Thanks for looking into it @phillip-kruger
I also took a deeper look into it and I think I have a simple solution for the problem:
crissi98@786a9d7

@phillip-kruger
Copy link
Member

Hi @crissi98 that looks right, will you do a PR with that change ?

@brunohorta82
Copy link

I confirm this bug

@crissi98
Copy link
Author

Closing this as it is fixed by #10774

@gsmet gsmet added this to the 1.6.1.Final milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/openapi kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants