Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account the RESTEasy path in SmallRye OpenAPI #10774

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Take into account the RESTEasy path in SmallRye OpenAPI #10774

merged 3 commits into from
Jul 17, 2020

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 16, 2020

This is another version of what was proposed here: #10636 .

It's based on build items which is cleaner and (hopefully) takes all the cases into account.

Also I added some tests.

@gsmet gsmet requested a review from phillip-kruger July 16, 2020 11:23
@gsmet gsmet mentioned this pull request Jul 16, 2020
Closed
kenfinnigan
kenfinnigan approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@kenfinnigan kenfinnigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a brief look

phillip-kruger
phillip-kruger approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :)

@phillip-kruger
Copy link
Member

Fixes #10616

@crissi98
Copy link

LGTM. Thanks for fixing it :)

@gsmet gsmet merged commit faa1d7e into quarkusio:master Jul 17, 2020
@crissi98 crissi98 mentioned this pull request Jul 17, 2020
Closed
@gsmet gsmet added this to the 1.6.1.Final milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenfinnigan kenfinnigan kenfinnigan approved these changes

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
area/resteasy-classic area/smallrye
Projects
None yet
Milestone
1.6.1.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@gsmet @phillip-kruger @crissi98 @kenfinnigan