Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates are not being picked up when using minikube and jib extension together #10747

Closed
iocanel opened this issue Jul 15, 2020 · 1 comment · Fixed by #10755
Closed

Updates are not being picked up when using minikube and jib extension together #10747

iocanel opened this issue Jul 15, 2020 · 1 comment · Fixed by #10755
Assignees
@geoand
Labels
area/container-image area/kubernetes kind/bug Something isn't working
Milestone
1.6.1.Final

Comments

@iocanel
Copy link
Contributor

iocanel commented Jul 15, 2020

Describe the bug

Changes made to the app when using jib and minikube extension are not reflected in the deployed application.
It's possible that due to the nature of jib (dockerless?) that the image never reaches the minikube docker daemon.

Steps to reproduce

  1. create a quarkus app
mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:create -DprojectGroupId=org.acme -DprojectArtifactId=hello-world --DprojectVersion=0.1-SNAPSHOT -Dendpoint=/hello -DclassName=org.acme.Hello
  1. add minikube extension
mvn quarkus:add-extension -Dextensions="io.quarkus:quarkus-minikube"
  1. add jib extension
mvn quarkus:add-extension -Dextensions="io.quarkus:quarkus-container-image-jib"
  1. deploy
mvn clean install -Dquarkus.kubernetes.deploy=true

  1. Change the message in Hello.java

  2. redeploy

mvn clean install -Dquarkus.kubernetes.deploy=true
@quarkusbot
Copy link

/cc @geoand

@geoand geoand self-assigned this Jul 15, 2020
geoand added a commit to geoand/quarkus that referenced this issue Jul 15, 2020
@geoand
When minikube is being used, never push an container-image
987fe2e 
Fixes: quarkusio#10747
@geoand geoand mentioned this issue Jul 15, 2020
Merged
geoand added a commit to geoand/quarkus that referenced this issue Jul 16, 2020
@geoand
When minikube is being used, never push an container-image
e910479 
Fixes: quarkusio#10747
geoand added a commit to geoand/quarkus that referenced this issue Jul 16, 2020
@geoand
When minikube is being used, never push an container-image
088ee02 
Fixes: quarkusio#10747
geoand added a commit to geoand/quarkus that referenced this issue Jul 16, 2020
@geoand
When minikube is being used, never push an container-image
673ed88 
Fixes: quarkusio#10747
@snowdrop-bot snowdrop-bot mentioned this issue Jul 16, 2020
Closed
geoand added a commit that referenced this issue Jul 16, 2020
@geoand
Merge pull request #10755 from geoand/#10747
b663ebf 
When minikube is being used, never push a container-image
@gsmet gsmet changed the title Updates are not being picked up when using minkube and jib extension together Updates are not being picked up when using minikube and jib extension together Jul 17, 2020
@gsmet gsmet added this to the 1.6.1.Final milestone Jul 17, 2020
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jul 17, 2020
@geoand @gsmet
When minikube is being used, never push an container-image
2750309 
Fixes: quarkusio#10747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoand geoand

Labels
area/container-image area/kubernetes kind/bug Something isn't working
Projects
None yet
Milestone
1.6.1.Final
Development

Successfully merging a pull request may close this issue.

When minikube is being used, never push a container-image geoand/quarkus
4 participants
@iocanel @gsmet @geoand @quarkusbot