Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive routes - io.vertx.ext.web.RoutingContext.getBodyAsJson() may return null #10858

Closed
mkouba opened this issue Jul 20, 2020 · 3 comments · Fixed by #10871
Closed

Reactive routes - io.vertx.ext.web.RoutingContext.getBodyAsJson() may return null #10858

mkouba opened this issue Jul 20, 2020 · 3 comments · Fixed by #10871
Assignees
@mkouba
Labels
area/reactive area/vertx kind/bug Something isn't working
Milestone
1.7.0.CR1

Comments

@mkouba
Copy link
Contributor

mkouba commented Jul 20, 2020

No description provided.

@mkouba mkouba added kind/bug Something isn't working area/reactive area/vertx labels Jul 20, 2020
@mkouba mkouba self-assigned this Jul 20, 2020
@cescoffier
Copy link
Member

Do you have the body handler?

@mkouba
Copy link
Contributor Author

mkouba commented Jul 21, 2020

This is meant for cases where a client deliberately sends a request with empty body and the server uses @Body...

@cescoffier
Copy link
Member

ah ok! Nevermind!

mkouba added a commit to mkouba/quarkus that referenced this issue Jul 21, 2020
@mkouba
Reactive routes - handle RC.getBodyAsJson() returning null correctly
80db54d 
- also share the failure callback class for all routes returning Uni
- resolves quarkusio#10858
@mkouba mkouba mentioned this issue Jul 21, 2020
Merged
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkouba mkouba

Labels
area/reactive area/vertx kind/bug Something isn't working
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging a pull request may close this issue.

Reactive routes - handle RC.getBodyAsJson() returning null correctly mkouba/quarkus
3 participants
@cescoffier @mkouba @gsmet