Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes extension should not use version in labelselectors #11070

Closed
brokenjacobs opened this issue Jul 29, 2020 · 3 comments · Fixed by #11661
Closed

Kubernetes extension should not use version in labelselectors #11070

brokenjacobs opened this issue Jul 29, 2020 · 3 comments · Fixed by #11661
Assignees
Labels
Milestone

Comments

@brokenjacobs
Copy link

Describe the bug
When using manifests generated by the quarkus kubernetes extension, issues are encountered updating versions of deployed software. This is because labelselectors in deployments and other kubernetes objects are immutable. When using software such as fluxcd, the manifest is not able to be updated without deleting the old deployment, or naming the new deployment something else, as labelSelectors cannot be updated in a deployment manifest.

Expected behavior
LabelSelector will not include:
app.kubernetes.io/version

in the manifests generated

Actual behavior
app.kubernetes.io/version is included in the manifests

To Reproduce
Steps to reproduce the behavior:

  1. Generate build for a versioned release.
  2. Deploy the build to kubernetes
  3. Generate a build for a new version
  4. Try to apply manifests with kubectl apply. Observe failure due to immutable labelSelector.
@brokenjacobs brokenjacobs added the kind/bug Something isn't working label Jul 29, 2020
@quarkusbot
Copy link

/cc @geoand

@brokenjacobs
Copy link
Author

Slightly more nuanced here.. the labels that are used in the selector should be configurable.

@geoand
Copy link
Contributor

geoand commented Jul 29, 2020

I like the idea about the configurable labels in the selector.

@geoand geoand added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Jul 30, 2020
@geoand geoand added this to the 1.8.0 - master milestone Aug 27, 2020
geoand added a commit to geoand/quarkus that referenced this issue Aug 27, 2020
geoand added a commit to geoand/quarkus that referenced this issue Aug 27, 2020
geoand added a commit to geoand/quarkus that referenced this issue Aug 31, 2020
@gsmet gsmet removed this from the 1.8.0.CR1 milestone Sep 2, 2020
@iocanel iocanel self-assigned this Sep 22, 2020
iocanel pushed a commit to geoand/quarkus that referenced this issue Sep 23, 2020
geoand added a commit that referenced this issue Sep 23, 2020
Allow removing version from Kubernetes label selectors
@gsmet gsmet added this to the 1.9.0 - master milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants