-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes extension should not use version in labelselectors #11070
Comments
/cc @geoand |
Slightly more nuanced here.. the labels that are used in the selector should be configurable. |
I like the idea about the configurable labels in the selector. |
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Aug 27, 2020
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Aug 27, 2020
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Aug 31, 2020
iocanel
pushed a commit
to geoand/quarkus
that referenced
this issue
Sep 23, 2020
geoand
added a commit
that referenced
this issue
Sep 23, 2020
Allow removing version from Kubernetes label selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using manifests generated by the quarkus kubernetes extension, issues are encountered updating versions of deployed software. This is because labelselectors in deployments and other kubernetes objects are immutable. When using software such as fluxcd, the manifest is not able to be updated without deleting the old deployment, or naming the new deployment something else, as labelSelectors cannot be updated in a deployment manifest.
Expected behavior
LabelSelector will not include:
app.kubernetes.io/version
in the manifests generated
Actual behavior
app.kubernetes.io/version
is included in the manifestsTo Reproduce
Steps to reproduce the behavior:
The text was updated successfully, but these errors were encountered: