Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large numbers of security annotations will cause deployment to fail #11075

Closed
stuartwdouglas opened this issue Jul 30, 2020 · 2 comments · Fixed by #11112
Closed

Large numbers of security annotations will cause deployment to fail #11075

stuartwdouglas opened this issue Jul 30, 2020 · 2 comments · Fixed by #11112
Labels
kind/bug Something isn't working
Milestone
1.7.0.CR1

Comments

@stuartwdouglas
Copy link
Member

I noticed this when playing around with my large deployment generator, if you have more than around 1k security annotations you will get the following:

[ERROR] 	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#generateResources threw an exception: org.objectweb.asm.MethodTooLargeException: Method too large: io/quarkus/security/runtime/interceptor/SecurityCheckStorage_878ea92f854303317df5146707e738a696454a31_Synthetic_Bean.create (Ljavax/enterprise/context/spi/CreationalContext;)Lio/quarkus/security/runtime/interceptor/SecurityCheckStorage;
@stuartwdouglas stuartwdouglas added the kind/bug Something isn't working label Jul 30, 2020
stuartwdouglas added a commit to stuartwdouglas/quarkus that referenced this issue Jul 30, 2020
@stuartwdouglas
WIP: change security annotations to use recorded
57d1629 
Recorders automatically break up large methods

Fixes quarkusio#11075
@stuartwdouglas
Copy link
Member Author

@geoand I made a start on this here: https://github.com/stuartwdouglas/quarkus/tree/11075 but I need a bit of advice on how to handle the spring security stuff as I am not 100% sure what the semantics are supposed to be.

@geoand
Copy link
Contributor

geoand commented Jul 30, 2020

Looking now

stuartwdouglas added a commit to stuartwdouglas/quarkus that referenced this issue Jul 31, 2020
@stuartwdouglas
Change security annotations to use recorders
514d0e1 
Recorders automatically break up large methods

Fixes quarkusio#11075
@stuartwdouglas stuartwdouglas mentioned this issue Jul 31, 2020
Merged
@gsmet gsmet added this to the 1.7.0.CR1 milestone Jul 31, 2020
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jul 31, 2020
@stuartwdouglas @gsmet
Change security annotations to use recorders
e005f90 
Recorders automatically break up large methods

Fixes quarkusio#11075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging a pull request may close this issue.

Change security annotations to use recorders stuartwdouglas/quarkus
3 participants
@stuartwdouglas @gsmet @geoand