Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new config category quarkus.hibernate-orm.fetch #11527

Closed
knutwannheden opened this issue Aug 21, 2020 · 6 comments · Fixed by #11950
Closed

Add a new config category quarkus.hibernate-orm.fetch #11527

knutwannheden opened this issue Aug 21, 2020 · 6 comments · Fixed by #11950
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE good first issue Good for newcomers kind/enhancement New feature or request
Milestone

Comments

@knutwannheden
Copy link
Contributor

knutwannheden commented Aug 21, 2020

The options quarkus.hibernate-orm.batch-fetch-size and quarkus-hibernate-orm.max-fetch-depth both configure Hibernate's fetching logic and it would thus make sense to move them to a new config category quarkus.hibernate-orm.fetch. Of course for some time the original properties should be available as deprecated properties.

See also discussion in #11526.

@knutwannheden knutwannheden added the kind/enhancement New feature or request label Aug 21, 2020
@quarkusbot
Copy link

/cc @gsmet, @Sanne

@quarkusbot quarkusbot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Aug 21, 2020
@machi1990 machi1990 added the good first issue Good for newcomers label Aug 21, 2020
@gastaldi
Copy link
Contributor

I like @gavinking's suggestion in #11526 (comment)

Suggestion: add a new category hibernate-orm.fetch for stuff like this and the batch fetch batch size.

@knutwannheden knutwannheden changed the title Rename quarkus.hibernate-orm.batch-fetch-size to quarkus.hibernate-orm.query.batch-fetch-size Add a new config category quarkus.hibernate-orm.fetch Aug 24, 2020
@knutwannheden
Copy link
Contributor Author

I like @gavinking's suggestion in #11526 (comment)

I have updated the issue title and description accordingly.

@abhisht51
Copy link

Hi,
I am beginner at this issue. I get the idea of what we are try to achieve here but it would help if you can let me know what files I need to keep in mind @knutwannheden. Thanks

@rquinio
Copy link
Contributor

rquinio commented Aug 30, 2020

@abhisht51 That would be in https://github.com/quarkusio/quarkus/blob/master/extensions/hibernate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmConfigPersistenceUnit.java#L73-L89

My understanding is you need to find any reference to these in the extension, use the new properties but fallback to the deprecated ones if the new ones are not set, so it stays backward compatible.

@mkrzywanski
Copy link

Are there any test classes that test that those properties are actually set? Because I cannot find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants