Adding fetch configuration option to hibernate-orm module #11950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ent/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmConfigPersistenceUnit.java
Show resolved
Hide resolved
gavinking
reviewed
Sep 8, 2020
| * @asciidoclet | ||
| */ | ||
| @ConfigItem(defaultValue = "-1") | ||
| public int batchFetchSize; |
There was a problem hiding this comment.
Does this make the property name .fetch.batch-fetch-size? Can we eliminate the redundancy and call it .fetch.batch-size?
There was a problem hiding this comment.
Yes, new properties' names would be .fetch.batch-fetch-size and .fetch.max-fetch-depth. I am okay with removing the fetch keyword as far as redundancy is concerned. Shall we also do the same for maxFetchDepth so that it is .fetch.max-depth ?
There was a problem hiding this comment.
@mkrzywanski can you adjust the names and squash everything?
Thanks!
mkrzywanski
force-pushed
the
issue-11527
branch
3 times, most recently
from
68a1dd2 to
6f0e2b7
Compare
gsmet
reviewed
Sep 18, 2020
...ent/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmConfigPersistenceUnit.java
Outdated
Show resolved
Hide resolved
gsmet
approved these changes
Sep 18, 2020
gsmet
added
the
triage/waiting-for-ci
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should resolve #11527. New
fetchconfiguration category has been added. If those properties are not set, fallback for older depracted properties is done (if configured).