-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-Dquarkus.http.host=0.0.0.0 force set in s2i and jib despite it being the default #11911
Comments
/cc @geoand |
I also found it weird as well... We should definitely get rid of it as it's the default which is very unlikely to change at this point |
well even it was to change; isn't ones expectation that settings in application.properties should be listened too ? |
Yes for sure and this setting does indeed violate that expectation (although in all this time no one I have seen has tried to set |
yeah, very likely and thus just something to clean up to not trigger my ocd for clean settings ;) |
I'll do this over the weekend if you don't beat me to it :) |
There is no need to set these to 0.0.0.0 as that value is the default. Furthermore setting them in such a way means that if the property is set in application.properties, it will have no effect when running the container image Fixes: quarkusio#11911
#11918 takes care of this, but I am thinking we probably want to fix it for docker as well |
There is no need to set these to 0.0.0.0 as that value is the default. Furthermore setting them in such a way means that if the property is set in application.properties, it will have no effect when running the container image Fixes: quarkusio#11911
Drop quarkus.http.host setting from Jib and S2I
There is no need to set these to 0.0.0.0 as that value is the default. Furthermore setting them in such a way means that if the property is set in application.properties, it will have no effect when running the container image Fixes: quarkusio#11911
Describe the bug
just noticed that -Dquarkus.http.host=0.0.0.0 being set on various jvm/native arguments on https://quarkus.io/guides/all-config for s2i and jib.
Since #1307 that been the default value anyway and it also means any setting in application.properties will get ignored (afaics).
Is that really the intention ?
I would have expected default values to be used or what set in application.properties. I wonder if it was just done this way as the default was not set to make it work out of box back then....consequence now is though if we change it we do run the risk of breaking users since i their quarkus.http.host is set in application.properties - it would have been ignored by now for s2i and jib usecases.
We should though fix this imo (assuming there are no good reason we force them) and document it clearly.
The text was updated successfully, but these errors were encountered: