-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hibernate with jbang fails with class loader issue #11913
Comments
Could you expand on this? Why should we use such a fallback? One of the design goals in Quarkus was to use a flat classloader model (with the obvious exception of build time and dev mode). |
@maxandersen we will need a way to have integration tests run with jbang. Do you have a way? |
Looks like jbang is running it on JDK11 by default? In that case you need to adjust the dependencies, add
|
@stuartwdouglas should comment as he was the one suggesting the way to integrate. I.e. afaik I don't do anything much different from maven/gradle in that I just create a class loader with all the jars and then run from there. I'm equally surprised it's needed and I can see I'm bumping into it basically everywhere so I'm wondering if there is a better way for jbang to call out to the spi ... |
Also, see my complaints at : https://github.com/quarkusio/quarkus/wiki/Why-Dropping-Java-8#classpath-cleanup :) I feel like we should add the JDK11 specific dependencies, and stop supporting Java 8 as this is really getting in the way of people having fun with this all. |
I'll close this, I'll leave it to you @maxandersen to think if we can improve the user experience or tooling around this - personally I feel these requirements are already documented, and the pain points tracked on the wiki. In particular I'd highlight this section of the above-linked wiki:
That's perhaps something we can improve on, especially via jbang? |
I run integration tests in jbang itself with karate. Works pretty nice. Missing piece is install of jbang so it will be accessible in path but that should be pretty straight forward. Actually - can we assume access to docker? Then we can use the jbang docker image. |
it runs with users default jvm ... only gets jdk11 if it can't find anything else. |
i added those but not seeing a difference in behavior - it worked for you ? |
reopening until I can actually run it ;) and yes; if we can fix some of this in jbang thats great - not sure how though ... |
tried with java 8 and 11 and with and without the updated deps - same result. Did you get different result? |
hum, sorry yes it seemed to work but I forgot to use |
with #11957 this updated (as the original had bugs/was incomplete) works:
|
Describe the bug
use this code:
build/run it with:
jbang quarkusclidb.java
and you get:
Probably similar issue as in #11542 where we found places TCCL was not put as a fallback for class.forname.
The text was updated successfully, but these errors were encountered: