Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong work is parsing configuration VaultRuntimeConfig #11921

Closed
xumk opened this issue Sep 5, 2020 · 5 comments · Fixed by #12834
Closed

Wrong work is parsing configuration VaultRuntimeConfig #11921

xumk opened this issue Sep 5, 2020 · 5 comments · Fixed by #12834
Labels
area/vault kind/bug Something isn't working
Milestone

Comments

@xumk
Copy link
Contributor

xumk commented Sep 5, 2020

Class VaultConfigSource used it own parser for read app configuration with help regexp.
public static final Pattern SECRET_CONFIG_KV_PATH_PATTERN = Pattern .compile("^quarkus\\.vault\\.secret-config-kv-path\\.([^.]+)$");
VaultRuntimeConfig
@ConfigItem(name = "secret-config-kv-path.\"prefix\"") public Map<String, List<String>> secretConfigKvPrefixPath;
It regex does not parsing prefix string with dot char, example wrong work:
quarkus.vault.secret-config-kv-path."mp.jwt.verify"=myapps/app1

I think, need fix this regex or rewrite all class in microprofile style, similarly LogConfig class.
@ConfigItem(name = "category") @ConfigDocSection public Map<String, CategoryConfig> categories;

What do you think about this?

@xumk xumk added the kind/bug Something isn't working label Sep 5, 2020
@xumk xumk changed the title Wrong pattern for parsing VaultConfigSource Wrong work is parsing configuration VaultRuntimeConfig Sep 5, 2020
@sberyozkin
Copy link
Member

CC @vsevel

@vsevel
Copy link
Contributor

vsevel commented Sep 6, 2020

the plan is to move away from a dedicated parser. some support is expected fro the smallrye config project, as discussed here #9991 (comment)
@radcortez when do you think a 1.9 release might be available?

@radcortez
Copy link
Member

We were having a few issues with native mode that required a few changes. I think most of the work is done, so hopefully by the end of this week or next week.

@xumk
Copy link
Contributor Author

xumk commented Oct 10, 2020

@radcortez @vsevel
Hello, when can someone start solving this problem?

@radcortez
Copy link
Member

Hi @xumk.

Sorry for the delay. This is not forgotten and just recently we started another discussion with some ideas here: #12515

I should be able to dedicate some time next week. Cheers!

gastaldi added a commit that referenced this issue Oct 22, 2020
Add property expansion and dotted secret config kv path name in Vaut Config Source Fixes #10390 and #11921
@gsmet gsmet added this to the 1.10 - master milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vault kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants