Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven Model Merger is messing with properties order in Codestarts #12105

Closed
ia3andy opened this issue Sep 15, 2020 · 2 comments · Fixed by #12119
Closed

Maven Model Merger is messing with properties order in Codestarts #12105

ia3andy opened this issue Sep 15, 2020 · 2 comments · Fixed by #12119
Assignees
Milestone

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Sep 15, 2020

Description
properties are set in a specific order in the templates:

<properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
        <maven.compiler.source>{java.version}</maven.compiler.source>
        <maven.compiler.target>{java.version}</maven.compiler.target>
        <maven.compiler.parameters>true</maven.compiler.parameters>

        <quarkus.platform.group-id>{quarkus.platform.group-id}</quarkus.platform.group-id>
        <quarkus.platform.artifact-id>{quarkus.platform.artifact-id}</quarkus.platform.artifact-id>
        <quarkus.platform.version>{quarkus.platform.version}</quarkus.platform.version>
        <quarkus-plugin.version>{quarkus.maven-plugin.version}</quarkus-plugin.version>
        <compiler-plugin.version>{maven-compiler-plugin.version}</compiler-plugin.version>
        <surefire-plugin.version>{maven-surefire-plugin.version}</surefire-plugin.version>
    </properties>

then when merged, it ends up with something like:

<properties>
    <quarkus.platform.version>1.8.0.CR1</quarkus.platform.version>
    <scala-maven-plugin.version>4.1.1</scala-maven-plugin.version>
    <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
    <compiler-plugin.version>3.8.1</compiler-plugin.version>
    <surefire-plugin.version>2.22.1</surefire-plugin.version>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <maven.compiler.parameters>true</maven.compiler.parameters>
    <maven.compiler.source>11</maven.compiler.source>
    <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
    <maven.compiler.target>11</maven.compiler.target>
    <scala.version>2.12.8</scala.version>
    <quarkus-plugin.version>1.8.0.CR1</quarkus-plugin.version>
    <quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
  </properties>

I think it should just append the properties when merging (not reordering).

CC @gastaldi this is using the smart model merger.

@ia3andy ia3andy added the kind/enhancement New feature or request label Sep 15, 2020
@ia3andy ia3andy changed the title Maven Model Merger is messing with properties order Maven Model Merger is messing with properties order in Codestarts Sep 15, 2020
@quarkusbot
Copy link

/cc @quarkusio/devtools

@gastaldi gastaldi self-assigned this Sep 15, 2020
@gastaldi
Copy link
Contributor

I'll have a look

gastaldi added a commit to gastaldi/quarkus that referenced this issue Sep 15, 2020
gastaldi added a commit to gastaldi/quarkus that referenced this issue Sep 15, 2020
gastaldi added a commit to gastaldi/quarkus that referenced this issue Sep 15, 2020
gastaldi added a commit to gastaldi/quarkus that referenced this issue Sep 16, 2020
gastaldi added a commit to gastaldi/quarkus that referenced this issue Sep 16, 2020
@gsmet gsmet added this to the 1.9.0 - master milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants