Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary code in RestClientRecorder wrt ResteasyProviderFactory #12325

Closed
ronsigal opened this issue Sep 24, 2020 · 1 comment · Fixed by #12326
Closed

Remove unnecessary code in RestClientRecorder wrt ResteasyProviderFactory #12325

ronsigal opened this issue Sep 24, 2020 · 1 comment · Fixed by #12326
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone
1.9.0.CR1

Comments

@ronsigal
Copy link
Contributor

As of https://issues.redhat.com/browse/RESTEASY-2684 "Set providerFactory on ResteasyClientBuilderImpl", the code in io.quarkus.restclient.runtime.RestClientRecorder which configures ResteasyProviderFactory.instance is no longer necessary.
@ronsigal ronsigal added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Sep 24, 2020
ronsigal added a commit to ronsigal/quarkus that referenced this issue Sep 24, 2020
@ronsigal
[Quarkus issue quarkusio#12325] Remove unnecesary code from RestClien…
0246c4c 
…tRecorder.
@ronsigal ronsigal mentioned this issue Sep 24, 2020
Merged
ronsigal added a commit to ronsigal/quarkus that referenced this issue Sep 26, 2020
@ronsigal
[Quarkus issue quarkusio#12325] Remove unnecesary code from RestClien…
676eb98 
…tRecorder.

[quarkusio#12325] Add ResteasyClientBuilderImpl.setProviderFactory(clientProviderFactory) to RestClientRecorder
@kenfinnigan
Copy link
Member

Here's the PR: #12326

@gsmet gsmet mentioned this issue Oct 2, 2020
Merged
@gsmet gsmet added this to the 1.9.0 - master milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Milestone
1.9.0.CR1
Development

Successfully merging a pull request may close this issue.

Remove unnecessary code from RestClientRecorder ronsigal/quarkus
3 participants
@kenfinnigan @ronsigal @gsmet