Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include Twitter Bootstrap in quarkus-bom #12632

Closed
ge0ffrey opened this issue Oct 9, 2020 · 0 comments · Fixed by #12672
Closed

Do not include Twitter Bootstrap in quarkus-bom #12632

ge0ffrey opened this issue Oct 9, 2020 · 0 comments · Fixed by #12672
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@ge0ffrey
Copy link
Contributor

ge0ffrey commented Oct 9, 2020

The quarkus-bom should not enforce org.webjars:bootstrap:3.1.0, because it leads to a gradle build like this:

testRuntimeClasspath - Runtime classpath of source set 'test'.
+--- io.quarkus:quarkus-bom:1.8.2.Final
|    +--- io.quarkus:quarkus-hibernate-orm-panache:1.8.2.Final (c)
...
|    +--- org.webjars:bootstrap:3.1.0 (c)
...
+--- io.quarkus:quarkus-webjars-locator -> 1.8.2.Final
...
+--- org.webjars:bootstrap:4.3.1 -> 3.1.0 // <=================== Not good!
|    \--- org.webjars:jquery:1.9.0 -> 3.4.1
+--- org.webjars:jquery:3.4.1
...

which in turn leads to styling issues on the front end, which are hard to track down.

AFAIK, that twitter bootstrap webjar in quarkus-bom is only needed to test the quarkus-webjars-locator. It shouldn't trickle down to the quarkus users.

@Christopher-Chianelli ^^

@ge0ffrey ge0ffrey added the kind/bug Something isn't working label Oct 9, 2020
@gsmet gsmet self-assigned this Oct 9, 2020
gsmet added a commit to gsmet/quarkus that referenced this issue Oct 13, 2020
It should never have been added there.

Fix quarkusio#12632
@gsmet gsmet added this to the 1.10 - master milestone Oct 13, 2020
@gsmet gsmet modified the milestones: 1.10 - master, 1.9.0.Final Oct 13, 2020
gsmet added a commit to gsmet/quarkus that referenced this issue Oct 13, 2020
It should never have been added there.

Fix quarkusio#12632
xumk pushed a commit to xumk/quarkus that referenced this issue Oct 14, 2020
It should never have been added there.

Fix quarkusio#12632
@gsmet gsmet modified the milestones: 1.9.0.Final, 1.7.6.Final Nov 16, 2020
gsmet added a commit to gsmet/quarkus that referenced this issue Nov 16, 2020
It should never have been added there.

Fix quarkusio#12632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants